[SPH][NIMHD] Add Non-Ideal MHD terms by y-lapeyre · Pull Request #1765 · Shamrock-code/Shamrock

y-lapeyre · 2026-04-20T08:53:21Z

Add and enable the use of no-ideal MHD in the MHD solver, using the structure I previously set out for it.

Tests:

Wave Damping test: frequency is OK, amplitude is not (damping is too slow)
Standing shock: TBD

Could be merged as is and fixed with a 2nd PR that adds the wave damping CI test.

github-actions · 2026-04-20T08:53:31Z

Thanks @y-lapeyre for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

gemini-code-assist

Code Review

This pull request introduces support for Non-Ideal Magnetohydrodynamics (NIMHD) by adding Ohmic resistivity, Hall effect, and Ambipolar Diffusion terms. Key changes include the addition of NIMHD configuration parameters, mathematical kernels for current and heating terms, and a new CFL timestep constraint for Ambipolar Diffusion. Review feedback highlighted a critical architectural issue regarding the pairwise calculation of electric current, which should be a field quantity requiring a two-pass approach. Additionally, several potential division-by-zero bugs were identified in the mathematical kernels and timestep calculations, along with a likely incorrect gradient index in the induction term and misleading argument names in the Python bindings.

…/nonideal

y-lapeyre · 2026-06-04T08:47:27Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces support for Non-Ideal Magnetohydrodynamics (NIMHD) in the SPH solver, adding configuration parameters, mathematical formulations for current density and resistivity, and the corresponding derivative updates. However, several critical issues must be addressed: a bug where the current density J_a is passed by value instead of reference in MagCurrentJ_sum (discarding accumulated values), a race condition and event synchronization bug in the CFL timestep calculation due to variable shadowing, and potential out-of-bounds reads in compute_J from iterating over ghost particles that lack neighbor lists. Additionally, minor improvements are recommended, such as removing unused parameters in B_NI_terms, cleaning up a temporary comment, and renaming a Python binding parameter for consistency.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

y-lapeyre · 2026-06-04T13:56:22Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces Non-Ideal Magnetohydrodynamics (NIMHD) support to the SPH solver, including configurations for Ohmic resistivity, Hall effect, and Ambipolar diffusion, as well as the calculation of electric current density and non-ideal heating/induction terms. The review feedback highlights critical issues with SYCL event shadowing that can lead to concurrent kernel execution and data races on the timestep buffer. Other recommendations include evaluating the NIMHD flag at compile-time, skipping self-interactions in SPH neighbor loops, removing commented-out code, and resolving a developer query about the correct kernel gradient.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

y-lapeyre · 2026-06-15T17:25:23Z

/gemini review

…/nonideal

y-lapeyre · 2026-06-22T00:50:26Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces Non-Ideal Magnetohydrodynamics (NIMHD) support to the SPH solver, adding configuration parameters, a new ComputeJ module to calculate magnetic current density, and integration of non-ideal terms into the physical equations and solver timestep. However, several critical issues must be addressed: critical physics calculations (gas pressure forces and artificial viscosity) are currently commented out, invalid host logging calls are present inside SYCL device kernels which will break compilation, and there is duplicated unused code in UpdateDerivs.cpp. Additionally, an unprofessional variable name and an incorrect docstring should be cleaned up.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

github-actions · 2026-06-26T20:46:53Z

Workflow report

workflow report corresponding to commit d12fbe0
Commiter email is yona.lapeyre@ens-lyon.fr
GitHub page artifact URL GitHub page artifact link (can expire)

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report


328 warnings generated.
Suppressed 329 warnings (328 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1038:35: warning: redundant boolean literal supplied to boolean operator [readability-simplify-boolean-expr]
 1038 |         if (track_particles_id && false /*particle injection when added*/) {
      |             ~~~~~~~~~~~~~~~~~~~~~~^~~~~
      |             false
/__w/Shamrock/Shamrock/src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1038:13: note: FIX-IT applied suggested code changes
 1038 |         if (track_particles_id && false /*particle injection when added*/) {
      |             ^

600 warnings generated.
clang-tidy applied 1 of 1 suggested fixes.
Suppressed 600 warnings (598 in non-user code, 1 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

627 warnings generated.
Suppressed 628 warnings (627 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

627 warnings generated.
Suppressed 628 warnings (627 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

631 warnings generated.
Suppressed 632 warnings (631 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

631 warnings generated.
Suppressed 632 warnings (631 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

631 warnings generated.
Suppressed 632 warnings (631 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

614 warnings generated.
Suppressed 615 warnings (608 in non-user code, 6 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

736 warnings generated.
Suppressed 737 warnings (736 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

752 warnings generated.
Suppressed 753 warnings (752 in non-user code, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

1133 warnings generated.
Suppressed 1134 warnings (1035 in non-user code, 98 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

1155 warnings generated.
Suppressed 1156 warnings (1142 in non-user code, 13 due to line filter, 1 NOLINT).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

Suggested changes

Detailed changes :

diff --git a/src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp b/src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp
index 4f8a9134..3743e3b5 100644
--- a/src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp
+++ b/src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp
@@ -1035,7 +1035,7 @@ struct shammodels::sph::SolverConfig {
         dust_config.check_config();
         mhd_config.check_config();
 
-        if (track_particles_id && false /*particle injection when added*/) {
+        if (false /*particle injection when added*/) {
             shamrock::experimental_feature_check(
                 "particle injection is not yet compatible with particle id tracking");
         }

# Doxygen diff with `main` Removed warnings : 167 New warnings : 192 Warnings count : 7973 → 7998 (0.3%)

Detailed changes :

- src/shammodels/sph/include/shammodels/sph/Solver.hpp:215: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:219: warning: Member Solver(ShamrockCtx &context) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:223: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:227: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:227: warning: Member set_debug_dump(bool _do_debug_dump, std::string _debug_dump_filename) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:231: warning: Member print_timestep_logs() (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/Solver.hpp:245: warning: Member evolve_until(Tscal target_time, i32 niter_max, f64 max_walltime=-1) (function) of class shammodels::sph::Solver is not documented.
+ src/shammodels/sph/include/shammodels/sph/Solver.hpp:249: warning: Member evolve_until(Tscal target_time, i32 niter_max, f64 max_walltime=-1) (function) of class shammodels::sph::Solver is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1005: warning: Member use_luminosity(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1017: warning: Member check_config() (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1022: warning: Member use_luminosity(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1034: warning: Member check_config() (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1035: warning: Member set_layout(shamrock::patch::PatchDataLayerLayout &pdl) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1036: warning: Member set_ghost_layout(shamrock::patch::PatchDataLayerLayout &ghost_layout) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1058: warning: Member set_layout(shamrock::patch::PatchDataLayerLayout &pdl) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1059: warning: Member set_ghost_layout(shamrock::patch::PatchDataLayerLayout &ghost_layout) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1105: warning: Member to_json(nlohmann::json &j, const ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1118: warning: Member from_json(const nlohmann::json &j, ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1128: warning: Member to_json(nlohmann::json &j, const ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1133: warning: Member to_json(nlohmann::json &j, const SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1141: warning: Member from_json(const nlohmann::json &j, ParticleKillingConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1153: warning: Member from_json(const nlohmann::json &j, SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1156: warning: Member to_json(nlohmann::json &j, const SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1176: warning: Member from_json(const nlohmann::json &j, SmoothingLengthConfig &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1251: warning: Member to_json(nlohmann::json &j, const DustConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1259: warning: Member from_json(const nlohmann::json &j, DustConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1274: warning: Member to_json(nlohmann::json &j, const DustConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:1282: warning: Member from_json(const nlohmann::json &j, DustConfig< Tvec > &p) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:553: warning: Member DustConfig (typedef) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:554: warning: Member dust_config (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:564: warning: Member self_grav_config (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:567: warning: Member DustConfig (typedef) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:568: warning: Member dust_config (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:578: warning: Member self_grav_config (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:582: warning: Member show_neigh_stats (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:583: warning: Member set_show_neigh_stats(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:596: warning: Member show_neigh_stats (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:597: warning: Member set_show_neigh_stats(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:602: warning: Member smoothing_length_config (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:604: warning: Member set_smoothing_length_density_based() (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:607: warning: Member set_smoothing_length_density_based_neigh_lim(u32 max_neigh_count) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:611: warning: Member enable_particle_reordering (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:612: warning: Member set_enable_particle_reordering(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:613: warning: Member particle_reordering_step_freq (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:614: warning: Member set_particle_reordering_step_freq(u64 freq) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:616: warning: Member smoothing_length_config (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:618: warning: Member set_smoothing_length_density_based() (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:621: warning: Member set_smoothing_length_density_based_neigh_lim(u32 max_neigh_count) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:622: warning: Member save_dt_to_fields (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:623: warning: Member set_save_dt_to_fields(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:624: warning: Member should_save_dt_to_fields() const (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:625: warning: Member enable_particle_reordering (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:626: warning: Member set_enable_particle_reordering(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:626: warning: Member show_ghost_zone_graph (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:627: warning: Member particle_reordering_step_freq (variable) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:627: warning: Member set_show_ghost_zone_graph(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:628: warning: Member set_particle_reordering_step_freq(u64 freq) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:636: warning: Member save_dt_to_fields (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:637: warning: Member set_save_dt_to_fields(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:638: warning: Member should_save_dt_to_fields() const (function) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:640: warning: Member show_ghost_zone_graph (variable) of struct shammodels::sph::SolverConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:641: warning: Member set_show_ghost_zone_graph(bool enable) (function) of struct shammodels::sph::SolverConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:690: warning: The following parameter of shammodels::sph::SolverConfig::set_eos_polytropic(Tscal K, Tscal gamma) is not documented:
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:704: warning: The following parameter of shammodels::sph::SolverConfig::set_eos_polytropic(Tscal K, Tscal gamma) is not documented:
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:714: warning: The following parameter of shammodels::sph::SolverConfig::set_eos_locally_isothermalFA2014(Tscal h_over_r) is not documented:
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:714: warning: argument 'cs0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:714: warning: argument 'q' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:714: warning: argument 'r0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:728: warning: The following parameter of shammodels::sph::SolverConfig::set_eos_locally_isothermalFA2014(Tscal h_over_r) is not documented:
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:728: warning: argument 'cs0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:728: warning: argument 'q' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:728: warning: argument 'r0' of command @param is not found in the argument list of shammodels::sph::SolverConfig< Tvec, SPHKernel >::set_eos_locally_isothermalFA2014(Tscal h_over_r)
- src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:896: warning: The following parameter of shammodels::sph::SolverConfig::add_ext_force_paczynski_wiita(Tscal central_mass, Tvec central_pos, Tscal Racc) is not documented:
+ src/shammodels/sph/include/shammodels/sph/SolverConfig.hpp:910: warning: The following parameter of shammodels::sph::SolverConfig::add_ext_force_paczynski_wiita(Tscal central_mass, Tvec central_pos, Tscal Racc) is not documented:
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:117: warning: Member check_config() (function) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:28: warning: Compound shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:29: warning: Compound shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:32: warning: Compound shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:33: warning: Compound shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:34: warning: Member Tscal (typedef) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:35: warning: Member Tscal (typedef) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:35: warning: Member dim (variable) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:36: warning: Member dim (variable) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:39: warning: Compound shammodels::sph::MHDConfig::IdealMHD_constrained_hyper_para is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:40: warning: Compound shammodels::sph::MHDConfig::IdealMHD_constrained_hyper_para is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:40: warning: Member sigma_mhd (variable) of struct shammodels::sph::MHDConfig::IdealMHD_constrained_hyper_para is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:41: warning: Member alpha_u (variable) of struct shammodels::sph::MHDConfig::IdealMHD_constrained_hyper_para is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:41: warning: Member sigma_mhd (variable) of struct shammodels::sph::MHDConfig::IdealMHD_constrained_hyper_para is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:42: warning: Member alpha_u (variable) of struct shammodels::sph::MHDConfig::IdealMHD_constrained_hyper_para is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:44: warning: Compound shammodels::sph::MHDConfig::NonIdealMHD is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:45: warning: Compound shammodels::sph::MHDConfig::NonIdealMHD is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:45: warning: Member sigma_mhd (variable) of struct shammodels::sph::MHDConfig::NonIdealMHD is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:46: warning: Member alpha_u (variable) of struct shammodels::sph::MHDConfig::NonIdealMHD is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:46: warning: Member sigma_mhd (variable) of struct shammodels::sph::MHDConfig::NonIdealMHD is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:47: warning: Member alpha_u (variable) of struct shammodels::sph::MHDConfig::NonIdealMHD is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:48: warning: Member etaO (variable) of struct shammodels::sph::MHDConfig::NonIdealMHD is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:49: warning: Member etaH (variable) of struct shammodels::sph::MHDConfig::NonIdealMHD is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:50: warning: Member etaAD (variable) of struct shammodels::sph::MHDConfig::NonIdealMHD is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:53: warning: Member Variant (typedef) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:55: warning: Member config (variable) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:57: warning: Member Variant (typedef) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:57: warning: Member set(Variant v) (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:59: warning: Member configMHD (variable) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:59: warning: Member has_B_field() (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:61: warning: Member set(Variant v) (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:63: warning: Member do_NIMHD() (function) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:65: warning: Member has_psi_field() (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:68: warning: Member has_B_field() (function) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:71: warning: Member has_divB_field() (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:74: warning: Member has_psi_field() (function) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:76: warning: Member has_curlB_field() (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:80: warning: Member has_divB_field() (function) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:81: warning: Member has_dtdivB_field() (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:85: warning: Member has_curlB_field() (function) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:86: warning: Member print_status() (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:90: warning: Member has_dtdivB_field() (function) of struct shammodels::sph::MHDConfig is not documented.
+ src/shammodels/sph/include/shammodels/sph/config/MHDConfig.hpp:95: warning: Member print_status() (function) of struct shammodels::sph::MHDConfig is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:109: warning: Member lambda_artes(Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tscal vsigb, Tvec B_a, Tvec B_b, Tscal omega_a, Tscal omega_b, Tscal Fab_a, Tscal Fab_b) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:121: warning: Member B_dot_grad_W(Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tvec B_a, Tvec B_b, Tscal omega_a, Tscal omega_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb, Tscal mu_0) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:134: warning: Member dB_on_rho_induction_term(Tscal m_b, Tscal rho_a_sq, Tvec B_a, Tscal omega_a, Tvec nabla_Wab_ha) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:145: warning: Member dB_on_rho_psi_term(Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tscal psi_a, Tscal psi_b, Tscal omega_a, Tscal omega_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:147: warning: Member mag_tension(Tscal m_b, Tvec B_a, Tvec B_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb, Tscal sub_fact_a, Tscal sub_fact_b, Tscal mu_0) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:168: warning: Member dpsi_on_ch_parabolic_propag(Tscal m_b, Tscal rho_a, Tvec B_a, Tvec B_b, Tscal omega_a, Tvec nabla_Wab_ha, Tscal ch_a) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:176: warning: Member fdivB(Tscal m_b, Tvec B_a, Tvec B_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb, Tscal sub_fact_a, Tscal sub_fact_b, Tscal mu_0) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:183: warning: Member dpsi_on_ch_parabolic_diff(Tscal m_b, Tscal rho_a, Tvec v_ab, Tscal psi_a, Tscal omega_a, Tvec nabla_Wab_ha, Tscal ch_a) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:193: warning: Member lambda_artes(Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tscal vsigb, Tvec B_a, Tvec B_b, Tscal omega_a, Tscal omega_b, Tscal Fab_a, Tscal Fab_b) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:201: warning: Member add_to_derivs_spmhd(Tscal pmass, Tvec dr, Tscal rab, Tscal rho_a, Tscal rho_a_sq, Tscal omega_a_rho_a_inv, Tscal rho_a_inv, Tscal rho_b, Tscal omega_a, Tscal omega_b, Tscal Fab_a, Tscal Fab_b, Tvec vxyz_a, Tvec vxyz_b, Tscal u_a, Tscal u_b, Tscal P_a, Tscal P_b, Tscal cs_a, Tscal cs_b, Tscal h_a, Tscal h_b, Tscal alpha_u, Tvec B_a, Tvec B_b, Tscal psi_a, Tscal psi_b, Tscal mu_0, Tscal sigma_mhd, Tvec &dv_dt, Tscal &du_dt, Tvec &dB_on_rho_dt, Tscal &dpsi_on_ch_dt, Tscal &drho_dt, Tvec &mag_pressure, Tvec &mag_tension, Tvec &gas_pressure, Tvec &tensile_corr, Tscal &psi_propag, Tscal &psi_diff, Tscal &psi_cons, Tscal &u_pressure_viscous_heating) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:218: warning: Member dB_on_rho_induction_term(Tscal m_b, Tscal rho_a_sq, Tvec B_a, Tscal omega_a, Tvec nabla_Wab_ha) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:229: warning: Member dB_on_rho_psi_term(Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tscal psi_a, Tscal psi_b, Tscal omega_a, Tscal omega_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:252: warning: Member dpsi_on_ch_parabolic_propag(Tscal m_b, Tscal rho_a, Tvec B_a, Tvec B_b, Tscal omega_a, Tvec nabla_Wab_ha, Tscal ch_a) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:267: warning: Member dpsi_on_ch_parabolic_diff(Tscal m_b, Tscal rho_a, Tvec v_ab, Tscal psi_a, Tscal omega_a, Tvec nabla_Wab_ha, Tscal ch_a) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:285: warning: Member add_to_derivs_spmhd(Tscal pmass, Tvec dr, Tscal rab, Tscal rho_a, Tscal rho_a_sq, Tscal omega_a_rho_a_inv, Tscal rho_a_inv, Tscal rho_b, Tscal omega_a, Tscal omega_b, Tscal Fab_a, Tscal Fab_b, Tvec vxyz_a, Tvec vxyz_b, Tscal u_a, Tscal u_b, Tscal P_a, Tscal P_b, Tscal cs_a, Tscal cs_b, Tscal h_a, Tscal h_b, Tscal alpha_u, Tvec B_a, Tvec B_b, Tvec J_a, Tvec J_b, Tscal psi_a, Tscal psi_b, Tscal mu_0, Tscal sigma_mhd, Tscal etaO, Tscal etaH, Tscal etaAD, Tvec &dv_dt, Tscal &du_dt, Tvec &dB_on_rho_dt, Tscal &dpsi_on_ch_dt, Tscal &drho_dt, Tvec &mag_pressure, Tvec &mag_tension, Tvec &gas_pressure, Tvec &tensile_corr, Tscal &psi_propag, Tscal &psi_diff, Tscal &psi_cons, Tscal &u_pressure_viscous_heating) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:33: warning: Member MHDType (enumeration) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:34: warning: Member MHDType (enumeration) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:37: warning: Member B_dot_grad_W(Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tvec B_a, Tvec B_b, Tscal omega_a, Tscal omega_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb, Tscal mu_0) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:37: warning: Member MagCurrentJ_sum(Tscal m_b, Tvec B_a, Tvec B_b, Tvec nabla_Wab_ha, Tscal sub_fact_a, Tscal mu_0) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:47: warning: Member WursterD(Tvec B, Tvec J, Tscal etaO, Tscal etaH, Tscal etaAD) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:57: warning: Member u_NI_heating(Tvec B, Tvec J, Tscal rho, Tscal etaO, Tscal etaAD) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:63: warning: Member mag_tension(Tscal m_b, Tvec B_a, Tvec B_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb, Tscal sub_fact_a, Tscal sub_fact_b, Tscal mu_0) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:69: warning: Member B_NI_terms(Tvec D_a, Tvec D_b, Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tscal omega_a, Tscal omega_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:89: warning: Member B_NI_AD(Tscal eta_AD, Tvec J_a, Tvec J_b, Tscal m_b, Tscal rho_a_sq, Tscal rho_b_sq, Tvec B_a, Tvec B_b, Tscal omega_a, Tscal omega_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb) (function) of namespace shamrock::sph::mhd is not documented.
- src/shammodels/sph/include/shammodels/sph/math/mhd.hpp:92: warning: Member fdivB(Tscal m_b, Tvec B_a, Tvec B_b, Tvec nabla_Wab_ha, Tvec nabla_Wab_hb, Tscal sub_fact_a, Tscal sub_fact_b, Tscal mu_0) (function) of namespace shamrock::sph::mhd is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:28: warning: Compound shammodels::sph::modules::NodeComputeJ is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:38: warning: Member NodeComputeJ(Tscal part_mass, Tscal mu_0, Tscal c) (function) of class shammodels::sph::modules::NodeComputeJ is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:41: warning: Compound shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:42: warning: Member part_counts (variable) of struct shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:43: warning: Member neigh_cache (variable) of struct shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:44: warning: Member xyz (variable) of struct shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:45: warning: Member hpart (variable) of struct shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:46: warning: Member omega (variable) of struct shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:47: warning: Member B_on_rho (variable) of struct shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:48: warning: Member J (variable) of struct shammodels::sph::modules::NodeComputeJ::Edges is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:51: warning: Member set_edges(std::shared_ptr< shamrock::solvergraph::Indexes< u32 > > part_counts, std::shared_ptr< shammodels::sph::solvergraph::NeighCache > neigh_cache, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > xyz, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > hpart, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tscal > > omega, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > B_on_rho, std::shared_ptr< shamrock::solvergraph::IFieldSpan< Tvec > > J) (function) of class shammodels::sph::modules::NodeComputeJ is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/ComputeJ.hpp:63: warning: Member get_edges() (function) of class shammodels::sph::modules::NodeComputeJ is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:108: warning: Member MagCurrentJ_ghost (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:108: warning: Member old_dtepsilon (variable) of class shammodels::sph::SolverStorage is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:109: warning: Member MagCurrentJ (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:109: warning: Member old_dtdeltav (variable) of class shammodels::sph::SolverStorage is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:110: warning: Member exchange_gz_J (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:110: warning: Member old_ds_j_dt (variable) of class shammodels::sph::SolverStorage is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:112: warning: Member old_dtepsilon (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:112: warning: Member sinks (variable) of class shammodels::sph::SolverStorage is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:113: warning: Member old_dtdeltav (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:114: warning: Compound shammodels::sph::SolverStorage::Timings is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:114: warning: Member old_ds_j_dt (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:115: warning: Member interface (variable) of struct shammodels::sph::SolverStorage::Timings is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:116: warning: Member neighbors (variable) of struct shammodels::sph::SolverStorage::Timings is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:116: warning: Member sinks (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:117: warning: Member io (variable) of struct shammodels::sph::SolverStorage::Timings is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:118: warning: Compound shammodels::sph::SolverStorage::Timings is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:119: warning: Member interface (variable) of struct shammodels::sph::SolverStorage::Timings is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:120: warning: Member neighbors (variable) of struct shammodels::sph::SolverStorage::Timings is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:121: warning: Member io (variable) of struct shammodels::sph::SolverStorage::Timings is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:121: warning: Member timings_details (variable) of class shammodels::sph::SolverStorage is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/SolverStorage.hpp:125: warning: Member timings_details (variable) of class shammodels::sph::SolverStorage is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:28: warning: Compound shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:30: warning: Compound shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:30: warning: Member Tscal (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:31: warning: Member dim (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:32: warning: Member Kernel (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:32: warning: Member Tscal (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:33: warning: Member dim (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:34: warning: Member Config (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:34: warning: Member Kernel (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:35: warning: Member Storage (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:36: warning: Member Config (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:37: warning: Member Storage (typedef) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:37: warning: Member context (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:38: warning: Member solver_config (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:39: warning: Member context (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:39: warning: Member storage (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:40: warning: Member solver_config (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:41: warning: Member UpdateDerivs(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:41: warning: Member storage (variable) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:43: warning: Member UpdateDerivs(ShamrockCtx &context, Config &solver_config, Storage &storage) (function) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:44: warning: Member update_derivs(Tscal dt_hydro) (function) of class shammodels::sph::modules::UpdateDerivs is not documented.
+ src/shammodels/sph/include/shammodels/sph/modules/UpdateDerivs.hpp:46: warning: Member update_derivs(Tscal dt_hydro) (function) of class shammodels::sph::modules::UpdateDerivs is not documented.
- src/shammodels/sph/src/Solver.cpp:1572: warning: Member map_field_refs(PatchScheduler &sched, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
- src/shammodels/sph/src/Solver.cpp:1587: warning: Member map_field_refs_ext(PatchScheduler &sched, shambase::DistributedData< shamrock::patch::PatchDataLayer > &mpdats, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
- src/shammodels/sph/src/Solver.cpp:1606: warning: Member map_field_refs_ext(PatchScheduler &sched, shamrock::ComputeField< T > &field_data, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
+ src/shammodels/sph/src/Solver.cpp:1632: warning: Member map_field_refs(PatchScheduler &sched, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
+ src/shammodels/sph/src/Solver.cpp:1647: warning: Member map_field_refs_ext(PatchScheduler &sched, shambase::DistributedData< shamrock::patch::PatchDataLayer > &mpdats, u32 field_idx, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
+ src/shammodels/sph/src/Solver.cpp:1666: warning: Member map_field_refs_ext(PatchScheduler &sched, shamrock::ComputeField< T > &field_data, shamrock::solvergraph::FieldRefs< T > &refs) (function) of file Solver.cpp is not documented.
- src/shammodels/sph/src/Solver.cpp:611: warning: Compound shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:612: warning: Member Tscal (typedef) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:614: warning: Member nobj (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:615: warning: Member gpart_mass (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:616: warning: Compound shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:617: warning: Member Tscal (typedef) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:617: warning: Member buf_xyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:618: warning: Member buf_hpart (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:619: warning: Member buf_vxyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:619: warning: Member nobj (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:620: warning: Member gpart_mass (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:622: warning: Member buf_xyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:623: warning: Member buf_hpart (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
- src/shammodels/sph/src/Solver.cpp:623: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:624: warning: Member buf_vxyz (variable) of struct shammodels::sph::Debug_ph_dump is not documented.
+ src/shammodels/sph/src/Solver.cpp:628: warning: Member fill_blocks(PhantomDumpBlock &block, Debug_ph_dump< Tvec > &info) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/src/Solver.cpp:660: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
+ src/shammodels/sph/src/Solver.cpp:665: warning: Member make_interface_debug_phantom_dump(Debug_ph_dump< Tvec > info) (function) of namespace shammodels::sph is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1448: warning: Member add_analysisBarycenter_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1459: warning: Member add_analysisBarycenter_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1466: warning: Member add_analysisEnergyKinetic_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1477: warning: Member add_analysisEnergyKinetic_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1482: warning: Member add_analysisEnergyPotential_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1493: warning: Member add_analysisEnergyPotential_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1498: warning: Member add_analysisTotalMomentum_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1509: warning: Member add_analysisTotalMomentum_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1514: warning: Member add_analysisAngularMomentum_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1525: warning: Member add_analysisAngularMomentum_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1530: warning: Member add_analysisDustMass_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1541: warning: Member add_analysisDustMass_instance(py::module &m, const std::string &name_model) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1548: warning: Member analysis_impl(shammodels::sph::Model< Tvec, SPHKernel > &model) -> Analysis (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1553: warning: Member register_analysis_impl_for_each_kernel(py::module &msph, const char *name_class) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1559: warning: Member analysis_impl(shammodels::sph::Model< Tvec, SPHKernel > &model) -> Analysis (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1564: warning: Member register_analysis_impl_for_each_kernel(py::module &msph, const char *name_class) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1613: warning: Member ON_PYTHON_INIT (variable) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1616: warning: Member msph (variable) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1616: warning: documented symbol 'py::class_< EvolveUntilResults >' was not declared or defined.
- src/shammodels/sph/src/pySPHModel.cpp:1620: warning: Member def_readwrite("reach_niter_max", &EvolveUntilResults::reach_niter_max) .def_readwrite("reach_max_walltime" (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1622: warning: Member def_readwrite("iter_count", &EvolveUntilResults::iter_count) .def("__repr__" (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1623: warning: Member add_instance< f64_3, shammath::C2 >(msph, "SPHModel_f64_3_C2_SolverConfig", "SPHModel_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1623: warning: Member add_instance< f64_3, shammath::C4 >(msph, "SPHModel_f64_3_C4_SolverConfig", "SPHModel_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1623: warning: Member add_instance< f64_3, shammath::C6 >(msph, "SPHModel_f64_3_C6_SolverConfig", "SPHModel_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1623: warning: Member add_instance< f64_3, shammath::M4 >(msph, "SPHModel_f64_3_M4_SolverConfig", "SPHModel_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1623: warning: Member add_instance< f64_3, shammath::M6 >(msph, "SPHModel_f64_3_M6_SolverConfig", "SPHModel_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1623: warning: Member add_instance< f64_3, shammath::M8 >(msph, "SPHModel_f64_3_M8_SolverConfig", "SPHModel_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1623: warning: Member self (variable) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1624: warning: Member ON_PYTHON_INIT (variable) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1627: warning: Member msph (variable) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1627: warning: documented symbol 'py::class_< EvolveUntilResults >' was not declared or defined.
+ src/shammodels/sph/src/pySPHModel.cpp:1631: warning: Member def_readwrite("reach_niter_max", &EvolveUntilResults::reach_niter_max) .def_readwrite("reach_max_walltime" (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1633: warning: Member def_readwrite("iter_count", &EvolveUntilResults::iter_count) .def("__repr__" (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1634: warning: Member add_instance< f64_3, shammath::C2 >(msph, "SPHModel_f64_3_C2_SolverConfig", "SPHModel_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1634: warning: Member add_instance< f64_3, shammath::C4 >(msph, "SPHModel_f64_3_C4_SolverConfig", "SPHModel_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1634: warning: Member add_instance< f64_3, shammath::C6 >(msph, "SPHModel_f64_3_C6_SolverConfig", "SPHModel_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1634: warning: Member add_instance< f64_3, shammath::M4 >(msph, "SPHModel_f64_3_M4_SolverConfig", "SPHModel_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1634: warning: Member add_instance< f64_3, shammath::M6 >(msph, "SPHModel_f64_3_M6_SolverConfig", "SPHModel_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1634: warning: Member add_instance< f64_3, shammath::M8 >(msph, "SPHModel_f64_3_M8_SolverConfig", "SPHModel_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1634: warning: Member self (variable) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1643: warning: Member VariantSPHModelBind (typedef) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1651: warning: Member def("get_Model_SPH", [](ShamrockCtx &ctx, const std::string &vector_type, const std::string &kernel) -> VariantSPHModelBind { VariantSPHModelBind ret;if(vector_type=="f64_3" &&kernel=="M4") { ret=std::make_unique< Model< f64_3, shammath::M4 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="M6") { ret=std::make_unique< Model< f64_3, shammath::M6 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="M8") { ret=std::make_unique< Model< f64_3, shammath::M8 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="C2") { ret=std::make_unique< Model< f64_3, shammath::C2 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="C4") { ret=std::make_unique< Model< f64_3, shammath::C4 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="C6") { ret=std::make_unique< Model< f64_3, shammath::C6 > >(ctx);} else { throw shambase::make_except_with_loc< std::invalid_argument >("unknown combination of representation and kernel");} return ret;}, py::kw_only(), py::arg("context"), py::arg("vector_type"), py::arg("sph_kernel")) (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1651: warning: Member py::class_< shammodels::sph::modules::ISPHSetupNode, std::shared_ptr< shammodels::sph::modules::ISPHSetupNode > >(msph, "ISPHSetupNode") .def("get_dot" (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1654: warning: Member VariantSPHModelBind (typedef) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1662: warning: Member def("get_Model_SPH", [](ShamrockCtx &ctx, const std::string &vector_type, const std::string &kernel) -> VariantSPHModelBind { VariantSPHModelBind ret;if(vector_type=="f64_3" &&kernel=="M4") { ret=std::make_unique< Model< f64_3, shammath::M4 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="M6") { ret=std::make_unique< Model< f64_3, shammath::M6 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="M8") { ret=std::make_unique< Model< f64_3, shammath::M8 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="C2") { ret=std::make_unique< Model< f64_3, shammath::C2 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="C4") { ret=std::make_unique< Model< f64_3, shammath::C4 > >(ctx);} else if(vector_type=="f64_3" &&kernel=="C6") { ret=std::make_unique< Model< f64_3, shammath::C6 > >(ctx);} else { throw shambase::make_except_with_loc< std::invalid_argument >("unknown combination of representation and kernel");} return ret;}, py::kw_only(), py::arg("context"), py::arg("vector_type"), py::arg("sph_kernel")) (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1662: warning: Member py::class_< shammodels::sph::modules::ISPHSetupNode, std::shared_ptr< shammodels::sph::modules::ISPHSetupNode > >(msph, "ISPHSetupNode") .def("get_dot" (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::C2 >(msph, "AnalysisAngularMomentum_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::C4 >(msph, "AnalysisAngularMomentum_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::C6 >(msph, "AnalysisAngularMomentum_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::M4 >(msph, "AnalysisAngularMomentum_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::M6 >(msph, "AnalysisAngularMomentum_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::M8 >(msph, "AnalysisAngularMomentum_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisBarycenter_instance< f64_3, shammath::C2 >(msph, "AnalysisBarycenter_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisBarycenter_instance< f64_3, shammath::C4 >(msph, "AnalysisBarycenter_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisBarycenter_instance< f64_3, shammath::C6 >(msph, "AnalysisBarycenter_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisBarycenter_instance< f64_3, shammath::M4 >(msph, "AnalysisBarycenter_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisBarycenter_instance< f64_3, shammath::M6 >(msph, "AnalysisBarycenter_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisBarycenter_instance< f64_3, shammath::M8 >(msph, "AnalysisBarycenter_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisDustMass_instance< f64_3, shammath::C2 >(msph, "AnalysisDustMass_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisDustMass_instance< f64_3, shammath::C4 >(msph, "AnalysisDustMass_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisDustMass_instance< f64_3, shammath::C6 >(msph, "AnalysisDustMass_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisDustMass_instance< f64_3, shammath::M4 >(msph, "AnalysisDustMass_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisDustMass_instance< f64_3, shammath::M6 >(msph, "AnalysisDustMass_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisDustMass_instance< f64_3, shammath::M8 >(msph, "AnalysisDustMass_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::C2 >(msph, "AnalysisEnergyKinetic_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::C4 >(msph, "AnalysisEnergyKinetic_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::C6 >(msph, "AnalysisEnergyKinetic_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::M4 >(msph, "AnalysisEnergyKinetic_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::M6 >(msph, "AnalysisEnergyKinetic_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::M8 >(msph, "AnalysisEnergyKinetic_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::C2 >(msph, "AnalysisEnergyPotential_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::C4 >(msph, "AnalysisEnergyPotential_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::C6 >(msph, "AnalysisEnergyPotential_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::M4 >(msph, "AnalysisEnergyPotential_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::M6 >(msph, "AnalysisEnergyPotential_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::M8 >(msph, "AnalysisEnergyPotential_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::C2 >(msph, "AnalysisTotalMomentum_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::C4 >(msph, "AnalysisTotalMomentum_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::C6 >(msph, "AnalysisTotalMomentum_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::M4 >(msph, "AnalysisTotalMomentum_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::M6 >(msph, "AnalysisTotalMomentum_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::M8 >(msph, "AnalysisTotalMomentum_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisAngularMomentum >(msph, "analysisAngularMomentum") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisBarycenter >(msph, "analysisBarycenter") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisDustMass >(msph, "analysisDustMass") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisEnergyKinetic >(msph, "analysisEnergyKinetic") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisEnergyPotential >(msph, "analysisEnergyPotential") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1685: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisTotalMomentum >(msph, "analysisTotalMomentum") (function) of file pySPHModel.cpp is not documented.
- src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Found ';' while parsing initializer list! (doxygen could be confused by a macro call without semicolon)
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::C2 >(msph, "AnalysisAngularMomentum_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::C4 >(msph, "AnalysisAngularMomentum_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::C6 >(msph, "AnalysisAngularMomentum_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::M4 >(msph, "AnalysisAngularMomentum_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::M6 >(msph, "AnalysisAngularMomentum_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisAngularMomentum_instance< f64_3, shammath::M8 >(msph, "AnalysisAngularMomentum_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisBarycenter_instance< f64_3, shammath::C2 >(msph, "AnalysisBarycenter_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisBarycenter_instance< f64_3, shammath::C4 >(msph, "AnalysisBarycenter_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisBarycenter_instance< f64_3, shammath::C6 >(msph, "AnalysisBarycenter_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisBarycenter_instance< f64_3, shammath::M4 >(msph, "AnalysisBarycenter_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisBarycenter_instance< f64_3, shammath::M6 >(msph, "AnalysisBarycenter_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisBarycenter_instance< f64_3, shammath::M8 >(msph, "AnalysisBarycenter_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisDustMass_instance< f64_3, shammath::C2 >(msph, "AnalysisDustMass_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisDustMass_instance< f64_3, shammath::C4 >(msph, "AnalysisDustMass_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisDustMass_instance< f64_3, shammath::C6 >(msph, "AnalysisDustMass_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisDustMass_instance< f64_3, shammath::M4 >(msph, "AnalysisDustMass_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisDustMass_instance< f64_3, shammath::M6 >(msph, "AnalysisDustMass_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisDustMass_instance< f64_3, shammath::M8 >(msph, "AnalysisDustMass_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::C2 >(msph, "AnalysisEnergyKinetic_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::C4 >(msph, "AnalysisEnergyKinetic_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::C6 >(msph, "AnalysisEnergyKinetic_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::M4 >(msph, "AnalysisEnergyKinetic_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::M6 >(msph, "AnalysisEnergyKinetic_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyKinetic_instance< f64_3, shammath::M8 >(msph, "AnalysisEnergyKinetic_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::C2 >(msph, "AnalysisEnergyPotential_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::C4 >(msph, "AnalysisEnergyPotential_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::C6 >(msph, "AnalysisEnergyPotential_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::M4 >(msph, "AnalysisEnergyPotential_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::M6 >(msph, "AnalysisEnergyPotential_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisEnergyPotential_instance< f64_3, shammath::M8 >(msph, "AnalysisEnergyPotential_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::C2 >(msph, "AnalysisTotalMomentum_f64_3_C2") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::C4 >(msph, "AnalysisTotalMomentum_f64_3_C4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::C6 >(msph, "AnalysisTotalMomentum_f64_3_C6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::M4 >(msph, "AnalysisTotalMomentum_f64_3_M4") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::M6 >(msph, "AnalysisTotalMomentum_f64_3_M6") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member add_analysisTotalMomentum_instance< f64_3, shammath::M8 >(msph, "AnalysisTotalMomentum_f64_3_M8") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisAngularMomentum >(msph, "analysisAngularMomentum") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisBarycenter >(msph, "analysisBarycenter") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisDustMass >(msph, "analysisDustMass") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisEnergyKinetic >(msph, "analysisEnergyKinetic") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisEnergyPotential >(msph, "analysisEnergyPotential") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1696: warning: Member register_analysis_impl_for_each_kernel< modules::AnalysisTotalMomentum >(msph, "analysisTotalMomentum") (function) of file pySPHModel.cpp is not documented.
+ src/shammodels/sph/src/pySPHModel.cpp:1707: warning: Found ';' while parsing initializer list! (doxygen could be confused by a macro call without semicolon)

codecov · 2026-06-26T20:47:00Z

Codecov Report

❌ Patch coverage is 2.45232% with 358 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/shammodels/sph/src/Solver.cpp	0.00%	120 Missing ⚠️
src/shammodels/sph/src/modules/ComputeJ.cpp	0.00%	67 Missing ⚠️
src/shammodels/sph/src/modules/UpdateDerivs.cpp	0.00%	62 Missing ⚠️
...shammodels/sph/include/shammodels/sph/math/mhd.hpp	0.00%	51 Missing ⚠️
...models/sph/include/shammodels/sph/SolverConfig.hpp	0.00%	19 Missing ⚠️
...ls/sph/include/shammodels/sph/config/MHDConfig.hpp	0.00%	18 Missing ⚠️
...ls/sph/include/shammodels/sph/modules/ComputeJ.hpp	0.00%	15 Missing ⚠️
src/shammodels/sph/src/SolverConfig.cpp	0.00%	4 Missing ⚠️
src/shammodels/sph/src/pySPHModel.cpp	81.81%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

tdavidcl · 2026-07-06T15:54:52Z

+        logger::raw_ln("$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$");
+        logger::raw_ln(" ______   _______  __    _  _______  _______  ______  ");
+        logger::raw_ln("|      | |   _   ||  |  | ||       ||       ||    _ | ");
+        logger::raw_ln("|  _    ||  |_|  ||   |_| ||    ___||    ___||   | ||");
+        logger::raw_ln("| | |   ||       ||       ||   | __ |   |___ |   |_||_");
+        logger::raw_ln("| |_|   ||       ||  _    ||   ||  ||    ___||    __  |");
+        logger::raw_ln("|       ||   _   || | |   ||   |_| ||   |___ |   |  | |");
+        logger::raw_ln("|______| |__| |__||_|  |__||_______||_______||___|  |_|");
+        logger::raw_ln("$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$");
+        logger::raw_ln("The Non-ideal MHD solver is UNDER DEVELOPMENT.");
+        logger::raw_ln("It is. NOT. FULLY. TESTED. YET.");
+        logger::raw_ln("Use at your own risk.");


Suggested change

logger::raw_ln("$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$");

logger::raw_ln(" ______ _______ __ _ _______ _______ ______ ");

logger::raw_ln("| | | _ || | | || || || _ | ");

logger::raw_ln("| _ || |_| || |_| || ___|| ___|| | ||");

logger::raw_ln("| | | || || || | __ | |___ | |_||_");

logger::raw_ln("| |_| || || _ || || || ___|| __ |");

logger::raw_ln("| || _ || | | || |_| || |___ | | | |");

logger::raw_ln("|______| |__| |__||_| |__||_______||_______||___| |_|");

logger::raw_ln("$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$DANGER$");

logger::raw_ln("The Non-ideal MHD solver is UNDER DEVELOPMENT.");

logger::raw_ln("It is. NOT. FULLY. TESTED. YET.");

logger::raw_ln("Use at your own risk.");

shamrock::experimental_feature_check(

"Non-ideal MHD is experimental, please enable experimental features to use it");

I low key want to change the expermental prompt with one similar to this though

tdavidcl · 2026-07-06T15:55:05Z

+    logger::raw_ln("xinside compute J");
+    logger::raw_ln("1111 c = ", c);


Suggested change

logger::raw_ln("xinside compute J");

logger::raw_ln("1111 c = ", c);

tdavidcl · 2026-07-06T15:55:10Z

+    auto edges = get_edges();
+
+    auto dev_sched = shamsys::instance::get_compute_scheduler_ptr();
+    logger::raw_ln("before ensure size");


Suggested change

logger::raw_ln("before ensure size");

tdavidcl · 2026-07-06T15:55:15Z

+    auto dev_sched = shamsys::instance::get_compute_scheduler_ptr();
+    logger::raw_ln("before ensure size");
+    edges.J.ensure_sizes(edges.part_counts.indexes);
+    logger::raw_ln("after ensure size");


Suggested change

logger::raw_ln("after ensure size");

tdavidcl · 2026-07-06T15:55:25Z

+    edges.part_counts.indexes.for_each([&](u64 id_patch, u32 count) {
+        fmt::print("patch {} has {} particles\n", id_patch, count);
+    });


Suggested change

edges.part_counts.indexes.for_each([&](u64 id_patch, u32 count) {

fmt::print("patch {} has {} particles\n", id_patch, count);

});

y-lapeyre added 5 commits March 17, 2026 13:28

add NIMHD terms

5b5fc0a

enable NIMHD

5f4c2ea

typos + correct dimentionality

a7ede8d

B -> Bhat

547a81d

Merge branch 'main' into MHD/nonideal

015819b

y-lapeyre added autofix.ci in-testing pre-commit.ci autofix labels Apr 20, 2026

pre-commit-ci Bot removed the pre-commit.ci autofix label Apr 20, 2026

gemini-code-assist Bot reviewed Apr 20, 2026

View reviewed changes

y-lapeyre added 4 commits May 4, 2026 09:53

correct summation for J

32aec9b

Merge branch 'MHD/nonideal' of github.com:y-lapeyre/Shamrock into MHD…

54d00cf

…/nonideal

Merge branch 'main' into MHD/nonideal

42428b4

fix potential division by 0

70586aa

gemini-code-assist Bot reviewed Jun 4, 2026

View reviewed changes

y-lapeyre added 4 commits June 4, 2026 10:54

fix pre-commit

23b20f0

correctly communicate J in ghosts

6636ce8

fix ghost com fields

071924a

clean up rogue J's

8b64f74

gemini-code-assist Bot reviewed Jun 4, 2026

View reviewed changes

tdavidcl changed the title ~~[non-ideal MHD] Add Non-Ideal MHD terms~~ [SPH][NIMHD] Add Non-Ideal MHD terms Jun 4, 2026

y-lapeyre added 4 commits June 7, 2026 12:11

remove logs

06c57c9

test1

347fa18

move computeJ to solvergraph

36ae82e

correct ghost communication

452bbcf

y-lapeyre force-pushed the MHD/nonideal branch from 06c57c9 to 23b20f0 Compare June 15, 2026 17:23

y-lapeyre added 5 commits June 18, 2026 22:58

remove logs

a9bd332

fix J handling (independant com)

140d56f

fix subfact

4ef2daf

fix dt_AD and J comm

b01a705

fixed memory issue

bf3c101

y-lapeyre force-pushed the MHD/nonideal branch from aaf9874 to bf3c101 Compare June 19, 2026 13:01

y-lapeyre and others added 5 commits June 22, 2026 00:36

Merge branch 'main' into MHD/nonideal

09caf22

[autofix.ci] automatic fix: pre-commit hooks

1d693f6

Merge branch 'MHD/nonideal' of github.com:y-lapeyre/Shamrock into MHD…

8ff7743

…/nonideal

Merge branch 'MHD/nonideal' of github.com:y-lapeyre/Shamrock into MHD…

2f1bb96

…/nonideal

clean up

02c1b44

y-lapeyre force-pushed the MHD/nonideal branch from 8a92b88 to 02c1b44 Compare June 22, 2026 00:49

gemini-code-assist Bot reviewed Jun 22, 2026

View reviewed changes

clean up + add warning

ffa662f

y-lapeyre requested a review from tdavidcl June 22, 2026 01:38

edit out typo

c956764

y-lapeyre force-pushed the MHD/nonideal branch from e875b51 to c956764 Compare June 22, 2026 07:41

y-lapeyre added 3 commits June 22, 2026 11:35

remove log

4fa54e6

Merge branch 'main' into MHD/nonideal

db3c168

correct wrongful merge deletion

b2456f5

tdavidcl reviewed Jun 26, 2026

View reviewed changes

y-lapeyre added 4 commits June 26, 2026 17:21

remove prints

3dbec73

add wave damping test runscript

60e828a

Put NIMHD in experimental mode

34f60c1

Merge branch 'main' into MHD/nonideal

d12fbe0

y-lapeyre requested a review from tdavidcl June 26, 2026 16:21

tdavidcl reviewed Jul 6, 2026

View reviewed changes

		logger::raw_ln("xinside compute J");
		logger::raw_ln("1111 c = ", c);

	edges.part_counts.indexes.for_each([&](u64 id_patch, u32 count) {
	fmt::print("patch {} has {} particles\n", id_patch, count);
	});

Uh oh!

Conversation

y-lapeyre commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 20, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

y-lapeyre commented Jun 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

y-lapeyre commented Jun 4, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

y-lapeyre commented Jun 15, 2026

Uh oh!

y-lapeyre commented Jun 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jun 26, 2026

Workflow report

Pre-commit check report

Clang-tidy diff report

Suggested changes

Uh oh!

codecov Bot commented Jun 26, 2026

Codecov Report

Uh oh!

tdavidcl Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

tdavidcl Jul 6, 2026

Choose a reason for hiding this comment

Uh oh!

y-lapeyre commented Apr 20, 2026 •

edited

Loading