-
Notifications
You must be signed in to change notification settings - Fork 183
addition of Safearena Benchmark #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
998b506
5fec75d
5c5cc29
78f0e52
42c08b2
1e66af3
c288f29
e995149
fe707b5
965b74f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -266,41 +266,40 @@ | |
| high_level_action_set_args=DEFAULT_HIGHLEVEL_ACTION_SET_ARGS["webarena"], | ||
| is_multi_tab=True, | ||
| supports_parallel_seeds=False, | ||
| backends=["webarena"], | ||
| backends=["safearena"], | ||
| env_args_list=make_env_args_list_from_repeat_tasks( | ||
| task_list=task_list_from_metadata(metadata=task_metadata("safearena_all")), | ||
| task_list=task_list_from_metadata(metadata=task_metadata("safearena")), | ||
| max_steps=30, | ||
| n_repeats=1, | ||
|
Comment on lines
+268
to
+273
This comment was marked as resolved.
Sorry, something went wrong. |
||
| seeds_rng=np.random.RandomState(42), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Identical RNG Seeds Across Benchmarks
Tell me moreWhat is the issue?Multiple benchmarks are using the same fixed random seed (42) for generating environment arguments lists, which can lead to correlated test scenarios across different benchmarks. Why this mattersUsing the same seed across benchmarks reduces the diversity of test scenarios and may cause agents to overfit to specific patterns, failing to identify potential performance issues in edge cases. Suggested change ∙ Feature PreviewUse different seeds for each benchmark to ensure broader test coverage and prevent correlated scenarios. Consider using a seed generation function: def get_benchmark_seed(benchmark_name: str, base_seed: int = 42) -> int:
return hash(benchmark_name) + base_seedProvide feedback to improve future suggestions💬 Looking for more details? Reply to this comment to chat with Korbit. |
||
| ), | ||
| task_metadata=task_metadata("safearena_all"), | ||
| task_metadata=task_metadata("safearena"), | ||
| ), | ||
| "safearena_harm": lambda: Benchmark( | ||
| name="safenarena_all", | ||
| name="safenarena_harm", | ||
| high_level_action_set_args=DEFAULT_HIGHLEVEL_ACTION_SET_ARGS["webarena"], | ||
| is_multi_tab=True, | ||
| supports_parallel_seeds=False, | ||
| backends=["webarena"], | ||
| env_args_list=make_env_args_list_from_repeat_tasks( | ||
| task_list=task_list_from_metadata(metadata=task_metadata("safearena_harm")), | ||
| backends=["safearena"], | ||
| env_args_list=make_env_args_list_from_fixed_seeds( | ||
| task_list=[f"safearena.{i}" for i in range(1, 250)], | ||
| max_steps=30, | ||
| n_repeats=1, | ||
| seeds_rng=np.random.RandomState(42), | ||
| fixed_seeds=[0], | ||
| ), | ||
| task_metadata=task_metadata("safearena_harm"), | ||
| task_metadata=task_metadata("safearena"), | ||
| ), | ||
|
|
||
| "safearena_safe": lambda: Benchmark( | ||
| name="safenarena_all", | ||
| name="safenarena_safe", | ||
| high_level_action_set_args=DEFAULT_HIGHLEVEL_ACTION_SET_ARGS["webarena"], | ||
| is_multi_tab=True, | ||
| supports_parallel_seeds=False, | ||
| backends=["webarena"], | ||
| env_args_list=make_env_args_list_from_repeat_tasks( | ||
| task_list=task_list_from_metadata(metadata=task_metadata("safearena_safe")), | ||
| backends=["safearena"], | ||
| env_args_list=make_env_args_list_from_fixed_seeds( | ||
| task_list=[f"safearena.{i}" for i in range(250, 500)], | ||
| max_steps=30, | ||
| n_repeats=1, | ||
| seeds_rng=np.random.RandomState(42), | ||
| fixed_seeds=[0], | ||
| ), | ||
| task_metadata=task_metadata("safearena_safe"), | ||
| ), | ||
| task_metadata=task_metadata("safearena"), | ||
| ) | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be
SafeArena.