Preserve iOS and Safari WebDriver sessions across commands - #22
Draft
cursor[bot] wants to merge 1 commit into
Draft
cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Co-authored-by: seanmcd15 <seanmcd15@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
After an iOS or Safari launch, command dispatch treated the missing CDP
BrowserManageras a missing browser. It implicitly launched local Chrome, routed subsequent actions away from WebDriver, and repeated provider launches replaced sessions without cleanup.Fix
Treat WebDriver as an active browser backend, reuse compatible iOS and Safari provider sessions, and centralize WebDriver/Appium/SafariDriver cleanup when changing or closing backends.
Validation
cargo +stable test(899 unit tests and 2 CLI tests passed)cargo +stable clippy --all-targetspassed with existing Rust 1.98-only lint categories allowed