Prevent close from losing unsaved restore state - #18
Draft
cursor[bot] wants to merge 2 commits into
Draft
cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: seanmcd15 <seanmcd15@gmail.com>
Co-authored-by: seanmcd15 <seanmcd15@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
When automatic restore persistence failed during
close, the daemon still destroyed the live browser and returned success. A full disk, invalid state path, or permission failure could therefore permanently discard fresh cookies and local storage while the CLI only printed “Browser closed.”Root cause
handle_closeretained the save error as response metadata but unconditionally calledclose_current_browser, then wrapped the failure in a successful response.Fix
Propagate automatic save failures before browser teardown so the close command fails and the live session remains available for retry. Added an end-to-end regression test that blocks state-directory creation and verifies the browser and its cookie remain intact.
Validation
cargo +stable fmt -- --checkcargo +stable test e2e_close_aborts_when_restore_state_cannot_be_saved -- --ignored --test-threads=1cargo +stable test(896 unit tests and 2 CLI integration tests passed)