Repository navigation
Various improvements of database tests - #433
Merged
Merged
Conversation
…isc, SetxSet, sSet also, sort the entries alphabetically
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds more data to
pnpm db:testand makes the JSON test files easier to maintain.More test data
Mon,CMon,Bin,Delta,M-Set,Pos,Set_disc,SetxSet, andsSetare now indecided-categories.json, so every property must be decided for them.FinSet,N, andwalking_morphism. Their properties must now match exactly, as forSet,Ab,Top, andforget_vector.Restructured JSON files
true/false. It now has two arrays,satisfiedandunsatisfied, and the test checks each property against the right array. This also fixesTop.json, where two satisfied properties (ℵ₁-filtered colimits,ℵ₁-cofiltered limits) were listed among the unsatisfied ones.decided-*.jsonfiles moved fromexpected-data/to their own folder,database/scripts/decided-structures/. Each folder has its own_INFO.md.Automatic sorting
pnpm db:sortsorts the arrays and object keys in all JSON files in both folders alphabetically and formats them with Prettier. It only writes files that change.db:update:db:sortnow runs first indb:update, so contributors can put a new property anywhere in these files.