Skip to content

Various improvements of database tests - #433

Merged
ScriptRaccoon merged 6 commits into
mainfrom
more-database-tests
Oct 25, 2026
Merged

ScriptRaccoon merged 6 commits into
mainfrom
more-database-tests

Conversation

@ScriptRaccoon

@ScriptRaccoon ScriptRaccoon commented Oct 25, 2026 •

Copy link
Copy Markdown
Owner

This PR adds more data to pnpm db:test and makes the JSON test files easier to maintain.

More test data

  • Decided categories: Mon, CMon, Bin, Delta, M-Set, Pos, Set_disc, SetxSet, and sSet are now in decided-categories.json, so every property must be decided for them.
  • Expected data: new files for FinSet, N, and walking_morphism. Their properties must now match exactly, as for Set, Ab, Top, and forget_vector.

Restructured JSON files

  • New format: each expected-data file used to be one object mapping property IDs to true/false. It now has two arrays, satisfied and unsatisfied, and the test checks each property against the right array. This also fixes Top.json, where two satisfied properties (ℵ₁-filtered colimits, ℵ₁-cofiltered limits) were listed among the unsatisfied ones.
  • New folder: the decided-*.json files moved from expected-data/ to their own folder, database/scripts/decided-structures/. Each folder has its own _INFO.md.

Automatic sorting

  • New script: pnpm db:sort sorts the arrays and object keys in all JSON files in both folders alphabetically and formats them with Prettier. It only writes files that change.
  • Part of db:update: db:sort now runs first in db:update, so contributors can put a new property anywhere in these files.

@ScriptRaccoon ScriptRaccoon added the feature features of the application visible to users as well as features for maintainers label Oct 25, 2026
@ScriptRaccoon
ScriptRaccoon merged commit eda6485 into main Oct 25, 2026
4 checks passed
@ScriptRaccoon
ScriptRaccoon deleted the more-database-tests branch October 25, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature features of the application visible to users as well as features for maintainers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant