feat(claude-code-settings): allow git marketplace URLs without .git suffix#5874
Open
esp0 wants to merge 1 commit into
Open
feat(claude-code-settings): allow git marketplace URLs without .git suffix#5874esp0 wants to merge 1 commit into
esp0 wants to merge 1 commit into
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by @domdomegg, @bogini, @sarahdeaton, and @ant-kurt - if they write a comment saying "LGTM" then it will be merged. |
…uffix Azure DevOps repo URLs (https://dev.azure.com/org/project/_git/repo) and AWS CodeCommit URLs never end in .git, but Claude Code's docs confirm the suffix is optional for the git marketplace source. Drop the overconstrained \.git$ pattern from extraKnownMarketplaces and blockedMarketplaces so these hosts validate, matching strictKnownMarketplaces which already has no such restriction.
esp0
force-pushed
the
claude-code-settings-azure-devops-git-url
branch
from
9b9f850 to
4253ba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extraKnownMarketplacesandblockedMarketplacesconstrain thegitsource'surlfield with a\.git$pattern. This rejects valid marketplace URLs from git hosts that don't use a.gitsuffix, such as Azure DevOps (https://dev.azure.com/org/project/_git/repo) and AWS CodeCommit.Per the official docs (Create and distribute a plugin marketplace):
\.git$pattern from bothextraKnownMarketplacesandblockedMarketplaces'sgitsourceurlfield. This also brings them in line withstrictKnownMarketplaces, which already has no such pattern on its equivalent field.urlfield descriptions, per CONTRIBUTING.md's convention of using<description>\n<url>.marketplace-host-pattern.jsonandmanaged-settings.json..gitsuffix is invalid" — that assumption no longer holds per the docs, and keeping them would fail Ajv's negative-test validation now that the pattern is gone.Test plan
node ./cli.js check --schema-name=claude-code-settings.jsonpassesnode ./cli.js coverage --schema-name=claude-code-settings.jsonpasses (8/8, strict mode)