Skip to content

Draft 04 migration#5858

Open
Vessel9817 wants to merge 6 commits into
SchemaStore:masterfrom
Vessel9817:draft-04-migration
Open

Draft 04 migration#5858
Vessel9817 wants to merge 6 commits into
SchemaStore:masterfrom
Vessel9817:draft-04-migration

Conversation

@Vessel9817

Copy link
Copy Markdown
Contributor

All local schemas are now using at least draft-07.

I apologize for the burden of labor reviewing this may incur. I acknowledge that I am a relatively new contributor. If it's of any assistance, I can provide the scripts I created to perform the bulk of these changes.

This commit was generated through the use of scripts, but absolutely no AI.

Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>
Signed-off-by: Vessel9817 <151808241+Vessel9817@users.noreply.github.com>

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory, this should supersede #5851, #5852 and #5853

@Vessel9817 Vessel9817 marked this pull request as ready for review June 27, 2026 03:13
@madskristensen

Copy link
Copy Markdown
Contributor

Too big a change. You've been sending a lot of PRs recently (thank you, btw). Why the sudden interest and why all the draft v7 updates?

@Vessel9817 Vessel9817 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently unemployed, so I'm primarily looking for ways to volunteer and build a portfolio through community involvement. I'd also like to find a team with which to integrate. Stripping the formalities, I'm bored and this was pretty simple. Can't say I didn't expect this PR to be put off or put down.

As for the migration, from CONTRIBUTING.md, section "Best Practices:"

"We recommend using the draft-07 JSON schema version. Later versions of JSON Schema are not yet recommended for use in SchemaStore..."

This makes draft-07 the current stable version, and versions prior legacy. Migration would encourage these best practices and potentially allow us to deprecate legacy versions- if that's in the project's interest. I've clumped together 200 tiny PRs into one, because I was surprised to see the migration guide only had one or two breaking changes, hence the automated intial commit.

Having all the time in the world, I would be happy to close this PR and submit 200 tiny PRs, particularly given the simplicity of changes. Doing so would also allow me to spend some time taking more schemas out of ajvNotStrictMode individually, much like in #5851.

I appreciate your candor and especially your extended time and commitment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants