-
Notifications
You must be signed in to change notification settings - Fork 6
rework of original background substraction #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
a872d72
rework of tool,added backsub dir
VictorDidier 1717723
added log
VictorDidier f4294ae
added logger and ome metadata writing
VictorDidier 05170c0
Update CLI.py
VictorDidier 3fa15eb
ome-xml encoded as utf-8 & output markers_bs.csv
VictorDidier 992421b
Merge branch 'main' of https://github.com/VictorDidier/Background_sub…
VictorDidier 4972111
encoded xml-ome string as utf-8
VictorDidier 4dbd49c
added saveRam argument
VictorDidier ae5a104
improved lazy loading of tiff images
VictorDidier 83b714b
changed chunksize
VictorDidier 96f9031
prefinal-version
VictorDidier 6123980
added hidden argument tspc-comet
VictorDidier 9d049a3
final rework
VictorDidier 23b472c
moved environment.yml to root folder,edited Dockerfile
VictorDidier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,89 @@ | ||
| import argparse | ||
| import pathlib | ||
| from argparse import ArgumentParser as AP | ||
|
|
||
| #---CLI-BLOCK---# | ||
| def get_args(): | ||
| # Script description | ||
| description=""" | ||
| Subtracts background from an image (signal) | ||
| acquired with fluorescence microscopy. | ||
| Subtraction is carried out via the formula (SignalImage-factor*BackgroundImage), | ||
| where factor is the ratio between exposure times of both images. | ||
| """ | ||
|
|
||
| # Add parser | ||
| parser = AP(description=description, formatter_class=argparse.RawDescriptionHelpFormatter) | ||
|
|
||
| # INPUTS | ||
| inputs = parser.add_argument_group(title="INPUTS") | ||
|
|
||
| inputs.add_argument("-r", | ||
| "--root", | ||
| dest="root", | ||
| action="store", | ||
| type=pathlib.Path, | ||
| required=True, | ||
| help="File path to root image file.") | ||
|
|
||
| inputs.add_argument("-m", | ||
| "--markers", | ||
| dest="markers", | ||
| action="store", | ||
| type=pathlib.Path, | ||
| required=True, | ||
| help="File path to required markers.csv file" | ||
| ) | ||
|
|
||
| inputs.add_argument("-mpp", | ||
| "--pixel-size", | ||
| metavar="SIZE", | ||
| dest = "pixel_size", | ||
| type=float, | ||
| default = None, | ||
| action = "store", | ||
| help="pixel size in microns,i.e. microns per pixel(mpp)" | ||
| ) | ||
|
|
||
|
|
||
| inputs.add_argument("-pl", | ||
| "--pyramid_levels", | ||
| dest="pyramid_levels", | ||
| required=False, | ||
| type=int, | ||
| default=8, | ||
| help="Tile size for pyramid generation" | ||
| ) | ||
|
|
||
|
|
||
| #VERSION CONTROL | ||
| inputs.add_argument("--version", | ||
| action="version", | ||
| version="v0.5.0" | ||
| ) | ||
|
|
||
| #OUTPUTS | ||
| outputs = parser.add_argument_group(title="OUTPUTS") | ||
|
|
||
| outputs.add_argument("-o", | ||
| "--output", | ||
| dest="output", | ||
| action="store", | ||
| type=pathlib.Path, | ||
| required=True, | ||
| help="Path to output file" | ||
| ) | ||
|
|
||
| outputs.add_argument("-mo", | ||
| "--marker-output", | ||
| dest="markerout", | ||
| action="store", | ||
| type=pathlib.Path, | ||
| required=True, | ||
| help="Path to output marker file" | ||
| ) | ||
|
|
||
| arg = parser.parse_args() | ||
|
|
||
| return arg | ||
| #---END_CLI-BLOCK---# | ||
Empty file.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,254 @@ | ||
| #standard libraries | ||
| import pandas as pd | ||
| import numpy as np | ||
| import tifffile as tifff | ||
| from loguru import logger | ||
| from skimage.transform import pyramid_gaussian | ||
| import time | ||
| import dask.array as da | ||
| from dask.diagnostics import ProgressBar,ResourceProfiler | ||
| import tracemalloc | ||
| #local libraries | ||
| import CLI | ||
| import ome_writer | ||
|
|
||
|
|
||
| def process_markers(markers): | ||
| markers['ind'] = range(0, len(markers)) | ||
| if 'remove' not in markers: | ||
| markers['remove'] = ["False" for i in range(len(markers))] | ||
| else: | ||
| markers['remove'] = markers['remove'] == True | ||
|
|
||
| markers['keep'] = markers['remove'] == False | ||
|
|
||
| markers = markers.drop(columns=['remove']) | ||
|
|
||
| markers.insert(markers.shape[1], "processed", ~ markers.background.isnull()) | ||
|
|
||
| scaling_factor=np.full(markers.shape[0],np.nan) | ||
| background_idx=np.full(markers.shape[0],np.nan) | ||
|
|
||
| for channel in range(len(markers)): | ||
|
|
||
| if markers.processed[channel]: | ||
| bg_idx = markers.loc[ markers.marker_name == markers.background[channel],"ind" ].tolist() | ||
|
|
||
| if len(bg_idx)>1: | ||
| pass | ||
| #TODO: RAISE WARNING OF REPEATED BACKGROUND ENTRIES IN MARKER_NAME COLUMN | ||
| else: | ||
| bg_idx=bg_idx[0] | ||
| scaling_factor[channel] = markers.exposure[channel] / markers.exposure[bg_idx] | ||
| background_idx[channel] = bg_idx | ||
|
|
||
| markers.insert(markers.shape[1], "factor", scaling_factor) | ||
| markers.insert(markers.shape[1], "bg_idx", background_idx) | ||
|
|
||
| return markers | ||
|
|
||
|
|
||
| def extract_img_props(img_path,pixel_size=None): | ||
|
|
||
|
|
||
|
|
||
| #pixel_size_unit="µm" | ||
| #Checks if image has pyramidal levels | ||
| with tifff.TiffFile(img_path) as tif: | ||
| pyr_levels=len(tif.series[0].levels) | ||
| is_pyramid=pyr_levels > 1 | ||
| data_type=tif.series[0].dtype.name | ||
| height,width=tif.series[0].shape[-2::] | ||
|
|
||
| #Try to extract pixel size from ome-xml | ||
| if pixel_size is None: | ||
| print('Pixel size not specified in the arguments (-mpp)') | ||
| try: | ||
| metadata = ome_types.from_tiff(img_path) | ||
| pixel_size = metadata.images[0].pixels.physical_size_x | ||
| pixel_size_unit = metadata.images[0].pixels.physical_size_x_unit | ||
| except Exception as err: | ||
| print(err) | ||
| print('Pixel size or pixel size unit detection using ome-types failed') | ||
| pixel_size = 1 | ||
| pixel_size_unit="pixel" | ||
| else: | ||
| pixel_size=0.001*pixel_size | ||
| pixel_size_unit="mm" | ||
|
|
||
|
|
||
| img_props={"pixel_size":pixel_size, | ||
| "pixel_size_unit":pixel_size_unit, | ||
| "data_type":data_type, | ||
| "pyramid":is_pyramid, | ||
| "levels":pyr_levels, | ||
| "size_x":width, | ||
| "size_y":height , | ||
| } | ||
|
|
||
| return img_props | ||
|
|
||
| def subtract_channels(src_img_path, markers_info,ref_dtype): | ||
| """ | ||
| This function executes the background substraction using generators, each element of the generator | ||
| is a tuple with 3 values, such that: | ||
|
|
||
| tuple=(img_with_backsub[array],calculate or extract pyramid [str],pyramid_from_index[int]) | ||
|
|
||
| The second entry of the tuple indicates in the writing process if the pyramid should be calculated using | ||
| pyramid_gaussian from scikit image. If extract, the index given in the third entry will fetch all the pyramid | ||
| levels from the original image stack(src_img_path). | ||
| """ | ||
| total_operations=markers_info['processed'].values.sum()#Count True values | ||
| count=1 | ||
| for _,channel in markers_info.iterrows(): | ||
|
|
||
| if channel.processed: | ||
| operation_count=f"({count}/{total_operations})" | ||
| factor=np.float32(channel.factor)#limiting precision to float32 saves memory | ||
|
|
||
| signal=da.from_array(tifff.imread(src_img_path,series=0,level=0,key=int(channel.ind)), chunks='auto') | ||
|
|
||
| background=da.from_array(tifff.imread(src_img_path,series=0,level=0,key=int(channel.bg_idx)), chunks=signal.chunksize) | ||
|
|
||
| subtraction=da.clip( signal-( da.rint(factor*background) ),0,65535).astype(ref_dtype) | ||
|
|
||
| print(f"\n {operation_count} Calculating subtraction of background {channel.background} from {channel.marker_name} signal:") | ||
|
|
||
| with ResourceProfiler(dt=0.25) as resources: | ||
| with ProgressBar(): | ||
| arr=subtraction.compute() | ||
|
|
||
| print(f"Resources used by dask during subtraction {operation_count}:") | ||
| print(resources.results[0],"([sec],[MB],[% CPU usage])") | ||
| count+=1 | ||
| yield (arr,"calculate",np.nan) | ||
|
|
||
| else: | ||
| yield ( tifff.imread(src_img_path,series=0,level=0,key=int(channel.ind)),"extract",int(channel.ind)) | ||
|
|
||
|
|
||
| def write_pyramid(img_instances, | ||
| src_img_path, | ||
| outdir, | ||
| levels, | ||
| file_name, | ||
| img_data_type, | ||
| calc_lvls=True | ||
| ): | ||
|
|
||
| outdir.mkdir(parents=True, exist_ok=True) | ||
| #out_file_path= outdir / f'{file_name}.tif' | ||
| out_file_path=outdir / file_name | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in main the outpath is given as an input for this function which treats it as the outdir - it should just be treated as the outpath here |
||
| sub_levels=levels-1 | ||
|
|
||
| with tifff.TiffWriter(out_file_path, ome=False, bigtiff=True) as tif: | ||
| #write first the original resolution image,i.e. first layer | ||
| for img,pyramid_action,chann_idx in img_instances: | ||
| first_layer=img | ||
| #Create pyramidal levels accordingly | ||
| if ( pyramid_action=="calculate" or calc_lvls ): | ||
| pyramid=pyramid_gaussian( first_layer, max_layer=sub_levels, preserve_range=True,order=1,sigma=1) | ||
|
|
||
| elif pyramid_action=="extract": | ||
| pyramid=( tifff.imread(src_img_path,series=0,level=L,key=chann_idx) for L in range(levels) ) | ||
|
|
||
| next(pyramid)#skip first layer | ||
| #Write first layer of the pyramid,i.e. full size image | ||
| tif.write( | ||
| first_layer.astype(img_data_type), | ||
| description="", | ||
| subifds=sub_levels, | ||
| metadata=False, # do not write tifffile metadata | ||
| tile=(256, 256), | ||
| photometric='minisblack', | ||
| compression="lzw" | ||
| ) | ||
|
|
||
| for sub_layer in pyramid: | ||
| tif.write( | ||
| sub_layer.astype(img_data_type), | ||
| subfiletype=1, | ||
| metadata=False, | ||
| tile=(256, 256), | ||
| photometric='minisblack', | ||
| compression="lzw"#lzw works better when saving channel-by-channel and jpeg 2000 when saving the whole stack at once | ||
| ) | ||
|
|
||
| return out_file_path | ||
|
|
||
|
|
||
| def main(version): | ||
| args=CLI.get_args() | ||
| in_path = args.root | ||
| out_path = args.output | ||
| #Pixel data is read into RAM lazily, cannot overwrite input file | ||
| assert out_path != in_path | ||
|
|
||
| # Extract image properties | ||
| src_props = extract_img_props(in_path, args.pixel_size,) | ||
| # Modify pyramid_levels if required | ||
| if src_props["pyramid"]: | ||
| levels=src_props["levels"] | ||
| else: | ||
| levels=args.pyramid_levels | ||
|
|
||
| #Update markers data_frame to include processing information | ||
| markers = process_markers(pd.read_csv(args.markers)) | ||
| markers_updated=markers.loc[ markers.keep] | ||
| logger.info("\nTASKS PREVIEW:\n{}",markers_updated) | ||
| tasks=1 | ||
| for _,channel in markers_updated.iterrows(): | ||
| if channel.processed: | ||
| print(f"\n({tasks})Channel {channel.marker_name} ({channel.background}) processed, background subtraction") | ||
| tasks+=1 | ||
| #Allocate subtraction operation using generators | ||
| img_generator=subtract_channels(in_path,markers_updated,src_props["data_type"]) | ||
|
|
||
| #Write pyramidal file | ||
| out_file_name=f"backsub_{in_path.stem}.ome.tif" | ||
| logger.info(f"\nTASKS PROGRESS" ) | ||
|
|
||
| print(f"\nCommencing writing of pyramidal ome.tif file into {out_path}/{out_file_name}") | ||
| print(f"\nCommencing subtraction tasks\n") | ||
|
|
||
| pyramid_abs_path=write_pyramid(img_generator, | ||
| in_path, | ||
| out_path, | ||
| levels, | ||
| out_file_name, | ||
| src_props["data_type"], | ||
| calc_lvls=(not src_props["pyramid"]) | ||
| ) | ||
|
|
||
| #Write metadata in OME format into the pyramidal file | ||
| channel_names=markers_updated["marker_name"].tolist() | ||
| ome_xml=ome_writer.create_ome(channel_names,src_props,version) | ||
| tifff.tiffcomment(pyramid_abs_path, ome_xml) | ||
|
|
||
| logger.info(f'\nSCRIPT FINISHED PROCESSING TASKS ') | ||
| print(f'\nPyramidal image with {levels} levels was successfully written ') | ||
|
|
||
|
|
||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| _version = 'v0.5.0' | ||
|
|
||
| # Run script | ||
| tracemalloc.start() | ||
| st = time.time() | ||
|
|
||
| main(_version) | ||
|
|
||
| logger.info(f'\nRESOURCES USED') | ||
| print("Memory peak:",((10**(-9))*tracemalloc.get_traced_memory()[1],"GB")) | ||
|
|
||
| rt = time.time() - st | ||
| tracemalloc.stop() | ||
| print(f"Script finished in {rt // 60:.0f}m {rt % 60:.0f}s") | ||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| name: backsub-env | ||
| channels: | ||
| - conda-forge | ||
| - defaults | ||
| dependencies: | ||
| - python=3.12.11 | ||
| - pandas=2.3.1 | ||
| - tifffile=2025.6.11 | ||
| - scikit-image=0.25.2 | ||
| - dask=2025.7.0 | ||
| - ome-types=0.6.0 | ||
| - numpy=2.3.2 | ||
| - loguru=0.7.3 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.