Fixed manifest writer to include properties attribute. - #31
Open
MichaelFenwick wants to merge 1 commit into
Open
Fixed manifest writer to include properties attribute.#31MichaelFenwick wants to merge 1 commit into
MichaelFenwick wants to merge 1 commit into
Conversation
After writing an epub, the manifest would end up with a `#nav` item which lacked a `properties` attribute. That is, the manifest item `<item href="nav.xhtml" id="nav" media-type="application/xhtml+xml" properties="nav"/>` would be written as `<item id="nav" href="nav.xhtml" media-type="application/xhtml+xml"/>` This is problematic as the manifest reader uses that attribute to identify the nav item, preventing a written book from being read again (an exception would be thrown if reading was attempted). This change ensures that the `properties` attribute is written to each manifest element if it has a value, resolving this problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After writing an epub, the manifest would end up with a
#navitem which lacked apropertiesattribute. That is, the manifest item<item href="nav.xhtml" id="nav" media-type="application/xhtml+xml" properties="nav"/>would be written as
<item id="nav" href="nav.xhtml" media-type="application/xhtml+xml"/>This is problematic as the manifest reader uses that attribute to identify the nav item, preventing a written book from being read again (an exception would be thrown if reading was attempted). This change ensures that the
propertiesattribute is written to each manifest element if it has a value, resolving this problem.