ci: use pull_request_target for fork PR secrets access - #56
Merged
Conversation
With pull_request, GitHub does not inject secrets for fork PRs (even after maintainer approval). pull_request_target runs the workflow YAML from the base branch so secrets are safely available. The _ci_pipeline already checks out the PR commit via head-sha, so no other changes are needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integration_test.ymltrigger frompull_requesttopull_request_targetso that fork PRs can access repository secrets (e.g.HTTP_PROXY,CCR_USERNAME/CCR_PASSWORD).Why
With
pull_request, GitHub does not inject secrets for fork PRs — even after maintainer approval. This causes CI to fail on any fork contribution.pull_request_targetruns the workflow YAML from the base branch (main), so:_ci_pipeline.ymlalready checks out the PR commit viahead-sha, so no other changes needed.Security model
main— forks cannot alter it.Test plan