Conversation
|
tysm for making this i hope he approves this |
|
Thanks for digging into this @forzayt. Falling back to the game view element on Enhanced was the right idea, and it is now on main in de34d1b. I could not merge this as it stands because of two things I hit while testing it in game:
What de34d1b does instead:
One limit worth knowing: the element's pixels cannot be read, so this only fixes the live viewfinder. Photos, clips, Live and video calls on Enhanced will still come out black until Cfx fixes game view capture (citizenfx/rfc#281). I have not been able to test on an Enhanced client myself. If you can try main and tell me whether the viewfinder shows up for you, that would help a lot. If 'auto' does not pick your server up, set Closing this in favour of that commit. |
|
Awesome, thanks for refining the logic and getting this implemented on main! It makes perfect sense why the drawImage method and static frame check were causing those issues. I'll test out the new commit on an Enhanced client as soon as I can and let you know if I run into any issues with the viewfinder. |
Summary
This pr focuses on the issue #287 which shows a black screen for everything in the game world on the mobile camera.
The existing cfx texture crashes while the game back buffer into Nui due to the enhanced version , so i added a simple fallback logic which will switch to a dom based element which enhanced version supports and it will produces on the targets camera..
Type of Change
Related Issues
Main intention to slove this one #287
Breaking Changes
Does this introduce any breaking changes?
No, cause this won't removes any existing codes legacy clients still uses the same logic as earlier , just adds up a simple fallback logic on the runtime which activates only on enhanced versions