Skip to content

Store filter parameters in URL#2115

Open
BragonSB wants to merge 3 commits into
masterfrom
brage/web-134-store-filter-parameters-in-url
Open

Store filter parameters in URL#2115
BragonSB wants to merge 3 commits into
masterfrom
brage/web-134-store-filter-parameters-in-url

Conversation

@BragonSB

Copy link
Copy Markdown
Contributor

Closes: WEB-134

@BragonSB BragonSB self-assigned this Mar 18, 2026
Comment thread frontend/src/Pages/EventsPage/components/EventsList/EventsList.tsx

@hei98 hei98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det ser ut som denne bare støtter søkefiltreringen så langt? Vi skal jo også legge til filtrering på kategori og lokaler (se web-97 og denne pr-en), så det kan være en idé å gjøre slik at den kan støtte flere filtre? Enten ved å strukturere det slik at man kan legge til flere query params for andre filtre eller legge til for kategori og lokaler.

@BragonSB
BragonSB requested review from 0xSpecter and hei98 March 23, 2026 21:32
@robines robines changed the title brage/web-134-store-filter-parameters-in-url Store filter parameters in URL Mar 24, 2026

@0xSpecter 0xSpecter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hei98 hei98 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser bedre ut nå:)

setSearchParam((prev) => {
const next = new URLSearchParams(prev);
if (query) {
next.set('search', query);

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan du endre parameteren fra search til q?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, gjorde det nå

@BragonSB
BragonSB requested a review from robines April 16, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants