Conversation
… streamlining project resources.
Introduces a persistent --mainnet CLI flag that selects the correct Bech32 address prefix before sdk.GetConfig().Seal() is called: - Default (testnet): addr_safro / addr_safrovaloper / addr_safrovalcons - --mainnet: safro / safrovaloper / safrovalcons os.Args is pre-scanned via getBech32Prefix() so the prefix is set before Cobra parses flags, which is required by the Cosmos SDK config seal contract.
feat: add --mainnet flag to switch Bech32 address prefix
danbaruka
added
enhancement
Remove --mainnet flag and runtime prefix switching; align with standard Cosmos practice (chain-id distinguishes networks, not HRP).
Bumps direct and transitive dependencies in both go.mod and interchaintest/go.mod to versions that fix the open Dependabot advisories surfaced on Safrochain-Org/safrochain-node. Direct upgrades (root + interchaintest): - github.com/cosmos/cosmos-sdk v0.50.13 -> v0.50.14 - github.com/CosmWasm/wasmd v0.54.0 -> v0.54.1 - github.com/cometbft/cometbft v0.38.17 -> v0.38.21 - google.golang.org/grpc v1.72.0 -> v1.79.3 - github.com/docker/docker (e2e only) v24.0.9 -> v25.0.14 Transitive minimum-version upgrades: - filippo.io/edwards25519 v1.1.0 -> v1.1.1 - github.com/go-jose/go-jose/v4 v4.0.4 -> v4.1.4 - github.com/hashicorp/go-getter v1.7.5 -> v1.8.6 - github.com/go-viper/mapstructure/v2 v2.2.1 -> v2.4.0 - github.com/ulikunitz/xz v0.5.11 -> v0.5.15 - go.opentelemetry.io/otel* v1.34.0 -> v1.43.0 - golang.org/x/crypto v0.37.0 -> v0.49.0 - golang.org/x/oauth2 v0.26.0 -> v0.36.0 - github.com/shamaton/msgpack/v2 v2.2.0 -> v2.4.0 interchaintest-only (e2e): - github.com/ethereum/go-ethereum v1.14.8 -> v1.17.2 - github.com/cosmos/interchain-security/v5 v5.1.1 -> v5.2.0 - github.com/consensys/gnark-crypto v0.12.1 -> v0.18.2 Other: - github.com/bytedance/sonic v1.13.2 -> v1.15.0 (required by Go 1.25 linkname rules) - enable the local replace github.com/Safrochain_Org/safrochain => ../ in interchaintest/go.mod (the prior commented placeholder pointed at a non-existent v1.0.0 tag) Toolchain: - go directive bumped from 1.23.9 to 1.25.8 in both go.mod files because several upgraded transitive dependencies now require Go 1.25. - CI workflows, Dockerfile, build_release.sh and .mise.toml updated to match. Alerts not addressed in this PR: - github.com/btcsuite/btcd (3 alerts): the patched 0.23.2+ releases remove the legacy btcec package that github.com/tendermint/tendermint v0.38.0-dev (pulled in transitively by interchaintest's namada chain support) still imports. Bumping breaks that build path. - github.com/docker/docker (2 alerts): the advisories request 29.3.1, which has not yet been published as a Go module. Bumped to v25.0.14 to close the two alerts that have available patches. - github.com/shamaton/msgpack/v2: no patched release yet; bumped to the latest available (v2.4.0).
security: bulk-resolve Dependabot alerts via dependency upgrades
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
--mainnetflag to allow runtime switching between mainnet and testnet Bech32 address prefixes"safro") and testnet ("addr_safro") prefixesgetBech32Prefix()function to inspectos.Argsbefore Cobra parses flags, since SDK config must be sealed earlyNewRootCmd()to dynamically set all Bech32 prefix variables based on the flag--mainnetflag with Cobra to prevent unknown flag errorsFixes #7
Details
This allows users to run the same binary with different address prefixes by passing
--mainnet, while maintaining backward compatibility with testnet as the default.