Context
After adding the annex plotting helpers, a source-tarball check runs to completion but still reports existing package hygiene warnings and notes.
Command used:
R CMD build --no-build-vignettes --no-manual .
R CMD check --no-manual --no-build-vignettes jjmR_1.2020.1.tar.gz
Current check status
R CMD check completes with 3 WARNINGs and 3 NOTEs.
Key groups:
- Non-ASCII characters in
R/jjm.diag-internal.R.
summary.jjm.diagnostics() has an S3 method signature mismatch: summary() expects function(object, ...), but the method currently uses function(x, ...).
- Several Rd files have undocumented usage arguments, including
changeNameModel, compareModels, getter, kobe, plot.jjm.diagnostics, plot_selectivities, runit, and summary.jjm.diagnostics.
man/dot-getJjmConfig.Rd reports a lost-braces warning around an escaped code tag.
- Code-analysis notes remain for tidy-eval/global-variable bindings and a few missing namespace imports.
doSNOW and pander are listed in Imports but are not detected as used.
Suggested repair sequence
- Apply low-risk syntax/Rd fixes first: ASCII comments/strings, S3 method signature, missing Rd arguments, and the escaped Rd code tag.
- Add missing namespace imports or
utils::globalVariables() declarations for tidy-eval symbols.
- Decide whether unused imports should stay because they are used indirectly by reports/examples, or move/remove them.
- Rerun source-tarball check and keep residual notes explicit.
Acceptance criteria
- Source tarball builds.
- Package installs.
R CMD check --no-manual --no-build-vignettes has fewer warnings/notes, with any remaining items documented.
Context
After adding the annex plotting helpers, a source-tarball check runs to completion but still reports existing package hygiene warnings and notes.
Command used:
R CMD build --no-build-vignettes --no-manual . R CMD check --no-manual --no-build-vignettes jjmR_1.2020.1.tar.gzCurrent check status
R CMD checkcompletes with 3 WARNINGs and 3 NOTEs.Key groups:
R/jjm.diag-internal.R.summary.jjm.diagnostics()has an S3 method signature mismatch:summary()expectsfunction(object, ...), but the method currently usesfunction(x, ...).changeNameModel,compareModels,getter,kobe,plot.jjm.diagnostics,plot_selectivities,runit, andsummary.jjm.diagnostics.man/dot-getJjmConfig.Rdreports a lost-braces warning around an escaped code tag.doSNOWandpanderare listed inImportsbut are not detected as used.Suggested repair sequence
utils::globalVariables()declarations for tidy-eval symbols.Acceptance criteria
R CMD check --no-manual --no-build-vignetteshas fewer warnings/notes, with any remaining items documented.