Skip to content

TypeIa SN models - #416

Merged
JostMigenda merged 4 commits into
jpkneller-pisn-modelsfrom
jpkneller-TypeIa
Jun 10, 2026
Merged

TypeIa SN models#416
JostMigenda merged 4 commits into
jpkneller-pisn-modelsfrom
jpkneller-TypeIa

Conversation

@jpkneller

Copy link
Copy Markdown
Contributor

No description provided.

@jpkneller

Copy link
Copy Markdown
Contributor Author

The Jupyter notebook SNOwGLoBES_models.ipynb can be removed.

@jpkneller

Copy link
Copy Markdown
Contributor Author

The TypeIa.ipynb notebook seems to be having trouble downloading the data from the repo. It downloads a fragment then stops. It is not clear to me why this happens because it's exactly the same code as for the other registry models. If the full dataset is supplied, the notebook works just fine.

@jpkneller
jpkneller marked this pull request as ready for review June 1, 2026 14:53
@JostMigenda
JostMigenda changed the base branch from main to jpkneller-pisn-models June 10, 2026 13:03
@JostMigenda

Copy link
Copy Markdown
Member

Since this PR is very similar to #415 and e.g. needs the updates to model_files.yml that are already included in that PR, I’ll merge this into that branch and review both of them at once (probably this afternoon).

@JostMigenda
JostMigenda merged commit 0b21198 into jpkneller-pisn-models Jun 10, 2026
7 of 14 checks passed
@jpkneller
jpkneller deleted the jpkneller-TypeIa branch July 13, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants