Implement logging over kafka - #147
Open
mlinvill wants to merge 3 commits into
Open
Conversation
Contributor
|
We should add a switch that disables this by default, so that testing copies of snews_cs don't all spam the ops topic. It could be on for the "real" server. What do to about multiple "real" servers? We'll cross that bridge when we come to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a Kafka log handler in the existing logging implementation using the Python standard logging library.
With this change, logs will be sent to
SNEWPLOG_TOPIC, currently defined askafka://${HOP_BROKER}/snews.operations, in addition to thesnews_cs.logfile. This feature is the first step in enabling the writing of log messages to the database viaSNEWS_DB_PIPELINE. Log messages can then be shared more widely via theSNEWS_Monitoring_Websiteinterface.Also, the location of the
snews_cs.logfile can now be overridden using aSNEWSLOG_DIRenvironment variable.Open questions: Do we need to control who can see specific log messages? Or are there concerns surrounding sharing log information more widely.