Bump seed-angular submodule: Personal Two-Factor Setup port - #5296
Closed
nllong wants to merge 1 commit into
Closed
Conversation
Points ng_seed/seed-angular at the port-personal-two-factor-setup branch tip (SEED-platform/seed-angular#80), which ports the legacy Personal Two-Factor Setup page (seed/static/seed/partials/two_factor_profile.html, two_factor_profile_controller, qr_code_scan_modal_controller, two_factor_service.js) to profile/two-factor in the new Angular app. No backend/legacy AngularJS changes — this only updates the submodule reference. Update this pointer again once seed-angular#80 merges to main. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
nllong
added
the
Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump seed-angular submodule: Personal Two-Factor Setup port
Companion PR to SEED-platform/seed-angular#80, which ports the legacy AngularJS "Personal
Two-Factor Setup" page (
seed/static/seed/partials/two_factor_profile.html,two_factor_profile_controller.js,qr_code_scan_modal_controller.js,two_factor_service.js) to the new Angular app atprofile/two-factor.What this PR does
ng_seed/seed-angularsubmodule pointer to theport-personal-two-factor-setupbranch tip in seed-angular (Port Personal Two-Factor Setup to Angular seed-angular#80).
(
seed/static/seed/) — the legacytwo_factor_profileroute keeps serving/app/trafficunchanged. This is purely a submodule reference update.
Why
The four
/api/v3/two_factor/endpoints this port relies on(
set_method,resend_token_email,generate_qr_code,verify_code) already exist inseed/views/v3/two_factor_views.pyand are unchanged — the Angular port calls them exactly asthe legacy controller did.
Validation
See SEED-platform/seed-angular#80 for the full write-up:
pnpm lint/pnpm buildpass, and thepage was live-tested end-to-end (email + token/QR methods, organization-enforced 2FA fallback,
dark mode, mobile viewport) against a throwaway backend built from this repo with seeded data.
Note
This pointer references seed-angular's
port-personal-two-factor-setupbranch tip, not yetmerged to seed-angular's
main. This PR should be updated (or the submodule bumped again) onceseed-angular#80 merges.