fix: initialize federateURL before proxy setup#230
Open
notque wants to merge 1 commit into
Open
Conversation
notque
requested review from
Kuckkuck,
LeoZhangZXZ,
ashifnihalb,
ibakshay,
joluc,
notandy,
richardtief,
timojohlo,
trouaux and
viennaa
as code owners
July 3, 2026 17:53
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes initialization order in the Prometheus storage client so federateURL is always set, even when an HTTP proxy is configured.
Changes:
- Move
federateURLinitialization above the proxy setup to ensure it runs on both code paths. - Keep proxy-specific HTTP client setup intact while avoiding early-return before
federateURLis computed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+51
to
+58
| if viper.IsSet("maia.proxy") { | ||
| proxyURL, err := url.Parse(viper.GetString("maia.proxy")) | ||
| if err != nil { | ||
| panic(fmt.Errorf("could not set proxy: %s .\n%s", proxyURL, err.Error())) | ||
| } | ||
| promCli.httpClient = &http.Client{Transport: &http.Transport{Proxy: http.ProxyURL(proxyURL)}} | ||
| return | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the federateURL initialization above the proxy setup block so it runs on both code paths.