Fix nil pointer dereference in SavePageData - #64
Merged
Merged
Conversation
When loadPageMetadata returns (nil, nil) because the meta file doesn't exist, SavePageData would proceed with a nil meta pointer, causing a nil pointer dereference at line 84 when appending to meta.Pages. Added nil check after loadPageMetadata to handle the case where the file doesn't exist yet - in that case we create a fresh PageMetadata with Status set to 'in_progress'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes nil pointer dereference at when returns for a missing meta file.
Root Cause
returns when the meta file doesn't exist yet. The existing code only checked for and proceeded with a nil pointer, causing a panic when accessing .
Fix
Changed the nil check from:
to:
This ensures a fresh is created when the file doesn't exist yet.
Testing