syscall: use O_PATH for directory traversal - #1052
Open
steadytao wants to merge 1 commit into
Open
Conversation
steadytao
force-pushed
the
fix/termux-destination-chdir
branch
2 times, most recently
from
August 13, 2026 19:24
baa4d45 to
de6b0c7
Compare
steadytao
force-pushed
the
fix/termux-destination-chdir
branch
from
August 13, 2026 19:32
de6b0c7 to
56e37ea
Compare
Closed
|
Noting that this PR also fixes our Landlock sandboxing issue in Homebrew: Homebrew/homebrew-core#298558 |
Member
Author
|
Ah, yes, it very well would. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1050
Summary
O_PATHfor intermediate directory descriptors in the ownership-checked path walk where supportedAndroid permits traversal through
/to/sdcardbut does not permit Termux to open/withO_RDONLY | O_DIRECTORY. The hardened destination walk therefore failed before reaching the destination even though the intermediate directories were searchable.