Skip to content

testsuite: make basis xname oracle deterministic - #1051

Merged
steadytao merged 1 commit into
RsyncProject:masterfrom
steadytao:fix/basis-xname-oracle
Aug 15, 2026
Merged

testsuite: make basis xname oracle deterministic#1051
steadytao merged 1 commit into
RsyncProject:masterfrom
steadytao:fix/basis-xname-oracle

Conversation

@steadytao

Copy link
Copy Markdown
Member

Addressing master CI failures.

Summary

  • replace the timing-sensitive FIFO oracle in basis-xname-traversal
  • trace the exact basedir and relpath passed to secure_basis_open()
  • preserve the malicious sender injection and forced-protocol coverage
  • remove platform-dependent retries and FIFO rendezvous timing

The existing FIFO oracle intermittently reports a vacuous run on NetBSD even though the same test passes in later runs without relevant source changes. The instrumented receiver observes the security decision directly therefore ../secret must not reach the basis open and linkdest/secret must be recorded.

@steadytao steadytao added run-ci and removed run-ci labels Aug 13, 2026
@steadytao
steadytao merged commit 195b4c6 into RsyncProject:master Aug 15, 2026
36 checks passed
@steadytao
steadytao deleted the fix/basis-xname-oracle branch August 15, 2026 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant