Hotfix Roomote 1.8.2: restore Slack channel history reads - #2682
Merged
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 14, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports the complete fix from #2681 onto the published
v1.8.1production baseline and generates the1.8.2patch release.Source and prerequisites
7aa6df38db34308b0a47127f12c9b6981c51ee9cc463f9d7ccd1eadc74c6e28fae534433eccdba10dbd93ed7a709a0119e3c7254811fda1c02223b99(v1.8.1)acd130a728fcecdf291b32210fc93047bb1c099emain.Version and exact scope
1.8.11.8.2packages/slack/src/slack-notifier.ts, its focused tests, and the API Slack channel lookup handler plus its focused test.package.jsonandCHANGELOG.md.developchanges, or pendingdevelopchangesets are included.The fix passes the caller's
oldestbound to Slack, retains a capped best-effort lookback for older thread roots with recent replies, and surfaces the underlying Slack error instead of a misleading generic failure.Validation
pnpm run versiongenerated1.8.2, consumed the hotfix changeset, and left only.changeset/README.mdand.changeset/config.jsonon the hotfix tree.git diff --check origin/main...HEADpassed.check-types:fast, and Knip.Live check
A real busy-channel Slack read is applicable, but no safe production-like Slack workspace/channel is connected to this sandbox. The request construction, bounded pagination, best-effort lookback failure, page cap, and API error propagation are covered deterministically by the backported tests. Treat the missing live check as an explicit release risk requiring maintainer acceptance or external verification before merge.
Release order
This PR must be merged into
mainwith a merge commit, never squash or rebase. Do not merge companion PR #2683 until all of these are verified:v1.8.2resolves to the released tree.v1.8.2is published.Companion PR: #2683
The existing unshipped
v1.9.0Promote PR #2625 remains separate and must not be merged out of release order.Rollback
Before tag publication, revert the hotfix merge commit if operationally safe. After publication, redeploy the previous immutable
v1.8.1images; never move, delete, or reuse a published tag. No data or schema cleanup is required.