[Refactor] Unify Telegram elicitation prompt retirement - #2649
Draft
roomote-roomote[bot] wants to merge 1 commit into
Draft
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
| messageId: params.messageId, | ||
| }); | ||
| if (params.replacementText !== undefined) { | ||
| await adapter.editMessageText({ |
Contributor
There was a problem hiding this comment.
If editMessageText fails, the record has already been rewritten without buttons, so this returns false and confirmAnswer posts a fallback confirmation without making another mutation to the original prompt. Its inline keyboard therefore remains visible until a later footer refresh (and can be clicked in the meantime). Previously the separate editMessageReplyMarkup call retired the keyboard before the text edit. On this failure path, also clear the reply markup best-effort, or otherwise preserve the old two-step cleanup behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Answer confirmation previously retired the keyboard through the SDK and then edited the same Telegram message again in the API handler. Splitting one lifecycle transition across layers created duplicate provider calls and left persisted footer text out of sync with the rendered confirmation.
Impact
Telegram answers now retire their prompt with one owned message mutation, and later managed-footer refreshes cannot restore the old prompt text or controls. Submission semantics and best-effort fallback delivery are unchanged.