Skip to content

[Fix] Memory page links render as blocked text - #2645

Open
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/memory-page-links-1sqqurqc68luj
Open

[Fix] Memory page links render as blocked text#2645
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/memory-page-links-1sqqurqc68luj

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. Follow up by mentioning @roomote-roomote, in the web UI, or in Slack.

What changed

  • Render canonical Memory page references such as people/... as in-app links instead of Streamdown's [blocked] placeholder.
  • Route those links through the same query-parameter selection used by the Memory browser while preserving existing URL parameters.
  • Keep arbitrary relative paths and unsafe URL protocols non-interactive, and add focused regression coverage for both allowed and blocked destinations.

Why this change was made

Task memories now include canonical person references, but their relative Markdown destinations were rejected by the preview's URL hardener. The stored relationship was correct while the visible initiator line appeared broken and could not open the referenced person page.

Impact

Admins can navigate from a memory's linked references to the corresponding page inside the existing Memory browser. The allowlist is limited to registered Memory namespaces and does not broaden access or bypass the existing admin-scoped page lookup.

Screenshots

Canonical person reference rendered as a link in the Memory browser

Representative Memory data was rendered on the real local product surface because the sandbox has no configured Memory service URL. This demonstrates the UI treatment; automated coverage verifies selection behavior and unsafe-link rejection.

@roomote-community

roomote-community Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 3aca95a

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 13, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant