Construct interface - #30
Open
mlanas wants to merge 12 commits into
Open
Conversation
missxa
reviewed
Apr 15, 2021
missxa
left a comment
missxa
left a comment
Contributor
There was a problem hiding this comment.
it's not ideal that the messages depend on each other, like middleware depends on simulation. can you avoid it?
| find_package(rosidl_default_generators REQUIRED) | ||
| find_package(std_msgs REQUIRED) | ||
| find_package(geometry_msgs REQUIRED) | ||
| find_package(roboy_simulation_msgs REQUIRED) |
Author
There was a problem hiding this comment.
I can move the LinkInformation msg from simulation to middleware, its only needed there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Topics implemented for the exoforce system to interface with the construct app.