[WIP] Correct spatial momentum calculations for fused links. - #24830
Open
mitiguy wants to merge 1 commit into
Open
[WIP] Correct spatial momentum calculations for fused links.#24830mitiguy wants to merge 1 commit into
mitiguy wants to merge 1 commit into
Conversation
mitiguy
commented
Aug 5, 2026
mitiguy
left a comment
Contributor
Author
There was a problem hiding this comment.
Updates spatial momentum calculations so we get correct results whether links are fused together or not.
Changes here:
- Changes in MultibodyTree::CalcBodiesSpatialMomentumInWorldAboutWo() and parallel changes to comments and code made in related method MultibodyTree:CalcSpatialInertia() -- whose signature includes std::vector.
- Uses new position and velocity kinematics calculations from PR# 24746.
- New unit tests in fused_welds_test.cc
- Some terminology cleanup to support wider use of "link" internally.
This PR is a separately-reviewable piece of the larger fused-body project issue #24350. There are no user-visible changes here unless fusing is enabled (which is "internal only" for now).
Note: To parallel CalcSpatialInertia(), anticipate a future PR to make a renamed CalcBodiesSpatialMomentumInWorldAboutWo() public into MultibodyPlant.
@mitiguy made 1 comment.
Reviewable status: needs platform reviewer assigned, needs at least two assigned reviewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is