[tools] Fix hermetic rules_python interpreters with version triples - #24720
Conversation
jwnimmer-tri
added
priority: low
release notes: fix
|
+a:@tyler-yankee for feature review or delegation, please. FYI @BetsyMcPhail. |
tyler-yankee
left a comment
tyler-yankee
left a comment
There was a problem hiding this comment.
@tyler-yankee reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: 1 unresolved discussion, needs platform reviewer assigned, needs at least two assigned reviewers (waiting on jwnimmer-tri).
tools/workspace/python/defs.bzl line 18 at r1 (raw file):
def _python_version_txt_impl(ctx): """Implementation of the python_version_text() rule, below."""
nit
Suggestion:
python_version_txt
Previously we assumed that python_version is always "major.minor", but in the case of hermetic interpreters it might be "major.minor.patch".
84ed23d to
35411a9
Compare
jwnimmer-tri
left a comment
jwnimmer-tri
left a comment
There was a problem hiding this comment.
+a:@sherm1 for platform review per schedule, please.
@jwnimmer-tri made 1 comment and resolved 1 discussion.
Reviewable status: LGTM missing from assignee sherm1(platform) (waiting on sherm1 and tyler-yankee).
sherm1
left a comment
sherm1
left a comment
There was a problem hiding this comment.
Platform
@sherm1 reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all discussions resolved, LGTM from assignees tyler-yankee,sherm1(platform) (waiting on jwnimmer-tri).
3 participants
Previously we assumed that python_version is always "major.minor", but in the case of hermetic interpreters it might be "major.minor.patch".
Towards #24719.
This change is