feat: add standalone TSRX runtime packages - #1398
Conversation
|
@aleclarson is attempting to deploy a commit to the Ripple Team Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix is ON, but it could not run because the branch was deleted or merged before autofix could start.
Reviewed by Cursor Bugbot for commit beccadb. Configure here.
|
|
||
| const real_path = to_real_path(id.split('?')[0]); | ||
| const source = await readFile(real_path, 'utf-8'); | ||
| let { code, css, map } = compile(source, real_path); |
There was a problem hiding this comment.
Solid Vite scan skips runtime option
Medium Severity
The Solid Vite plugin builds compile_options with runtimeImports and uses it in load, but the dep-scan plugin still passes the bare compile function. With runtimeImports: 'direct', optimizeDeps scanning emits compiler-package helper imports instead of @tsrx/solid-runtime, so the runtime package can be missed until request time.
Reviewed by Cursor Bugbot for commit beccadb. Configure here.


The default remains compiler-owned imports so existing applications need no dependency changes, while library publishers can opt into
runtimeImports: directand depend only on the core-free shared runtime plus the matching renderer runtime.Closes #1300.
Note
Medium Risk
Wide surface area across compile output and all bundler plugins, but default behavior is unchanged and coverage targets import paths and package boundaries.
Overview
Introduces
@tsrx/runtime(shared ref/iterable/language helpers) and per-renderer@tsrx/*-runtimepackages, moving implementations out of@tsrx/corewhile compiler packages re-export them for backward compatibility.Compilers gain
runtimeImports: 'compiler' | 'direct'(default unchanged). Indirectmode, emitted helper imports target the small runtime packages instead of@tsrx/react/ref-style compiler subpaths—intended for published libraries that should not depend on the compiler at runtime.The same option is threaded through Vite, Rspack, Bun, and React Turbopack plugins (including CSS re-compile and dep-scan paths). Tests and package-boundary checks verify emitted imports and that runtime packages stay free of
@tsrx/core.Reviewed by Cursor Bugbot for commit beccadb. Bugbot is set up for automated code reviews on this repo. Configure here.