feat: sort search page based on relevance - #5175
Open
Chew wants to merge 2 commits into
Open
Conversation
Contributor
Greptile SummarySearch sections now share relevance-based ordering.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Reviews (2): Last reviewed commit: "fallback for missing orders, rank them l..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
These could have technically always been an issue, but now falls back to being last.
wescopeland
reviewed
Aug 19, 2026
Member
There was a problem hiding this comment.
These new exports build a tight coupling between SearchResultsContainer and the global search component.
I recommend extracting SearchSection to a dedicated model file, ie search-section.model.ts, and extracting sortSections to a util (maybe renamed to sortSearchSections).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the logic found in SearchResults, specifically the sorting function and results wrapped in a SearchResult object, and brings it to SearchResultsContainer found on the
/searchpage.Using the scopeRelevance, which wasn't considered on this page before, and the sort function used in the modal should ensure the ordering is the same between the two pages, eliminating UX inconsistencies.
I just exported stuff from SearchResults, this doesn't seem to be an uncommon thing.