Preserve entity IDs in missing-type errors - #260
Draft
sapunyangkut wants to merge 1 commit into
Draft
Conversation
Collaborator
|
Looks good, thank you. Before merging, I need you to update author and copyright info. See the discussion in #252 for instructions. |
Contributor
|
@simleo the account that created this PR is brand new (2 weeks old) and spent last week opening 80 PRs against many different Python repos. I've seen no evidence that there is any human involvement in its contributions. It's up to you what you want to do with it - the PRs here look pretty harmless - but personally I don't look very favourably on PRs that aren't backed by a human who has reviewed the work before submitting it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@idavailable whilepick_typevalidates@type@idimmediately after successful type selection, preserving normal construction behavior@typeFixes #137.
Validation
git diff --checkand reverse-apply check passed in the current worktreeThe current system environment does not have the existing
arcpdependency, so pytest cannot collect here; no dependency was installed. A broader preserved diagnostic is not claimed as fully green because pre-existing network-dependent read tests timed out.AI assistance disclosure
This patch, tests, and pull request text were developed and checked with OpenAI Codex assistance. No independent human self-review is claimed; maintainer review is requested before merge.