Skip to content

Preserve entity IDs in missing-type errors - #260

Draft
sapunyangkut wants to merge 1 commit into
ResearchObject:masterfrom
sapunyangkut:codex/issue-137-preserve-entity-id
Draft

Preserve entity IDs in missing-type errors#260
sapunyangkut wants to merge 1 commit into
ResearchObject:masterfrom
sapunyangkut:codex/issue-137-preserve-entity-id

Conversation

@sapunyangkut

Copy link
Copy Markdown

Summary

  • keep each entity's @id available while pick_type validates @type
  • remove @id immediately after successful type selection, preserving normal construction behavior
  • add regression coverage for both referenced data entities and contextual entities missing @type

Fixes #137.

Validation

  • preserved evidence for this exact base and patch: targeted regression 2 passed; adjacent local read/profile/metadata tests 20 passed; narrow flake8 check passed
  • git diff --check and reverse-apply check passed in the current worktree

The current system environment does not have the existing arcp dependency, so pytest cannot collect here; no dependency was installed. A broader preserved diagnostic is not claimed as fully green because pre-existing network-dependent read tests timed out.

AI assistance disclosure

This patch, tests, and pull request text were developed and checked with OpenAI Codex assistance. No independent human self-review is claimed; maintainer review is requested before merge.

@simleo

simleo commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Looks good, thank you. Before merging, I need you to update author and copyright info. See the discussion in #252 for instructions.

@elichad

elichad commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@simleo the account that created this PR is brand new (2 weeks old) and spent last week opening 80 PRs against many different Python repos. I've seen no evidence that there is any human involvement in its contributions.

It's up to you what you want to do with it - the PRs here look pretty harmless - but personally I don't look very favourably on PRs that aren't backed by a human who has reviewed the work before submitting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken error message in pick_type

3 participants