-
Notifications
You must be signed in to change notification settings - Fork 39
Support for detached crates #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
9b4fa8f
add test_detached
simleo 815542b
test_detached: more checks
simleo fc025ec
find RDE id as prescribed by the spec
simleo c2dc3f3
support specifying RDE id when creating a new crate
simleo f72e7f5
expand test_detached_creation
simleo 3e3a079
add support for reading a crate from a remote URL
simleo 26a2071
add test_from_uri_detached
simleo 8fff3ab
add test sections to check the written crates
simleo 8e36253
support for reading crates from file: URIs
simleo 6f0cb47
update branch to master in test data URI
simleo 60be6d5
test_read.py: check reading from file: URI
simleo 190186c
support for reading crates from local metadata file
simleo 137e106
fix test_read on Windows
simleo 779762d
add write_detached
simleo 4d5f6bd
support referencing detached crates
simleo 567f169
remove non-json content type warning when reading from url
simleo 37a53d8
add a section on detached crates to the docs
simleo 5ca8aef
fix code highlighting in the docs
simleo 8382d29
Apply suggestions from code review
simleo 0955c89
clarify some bits in the docs
simleo 312a2a5
file.write: cut out path to the basename if it's a url and fetch_remo…
simleo 4e46b2c
file write: set localPath when dest path is set to basename
simleo dbd5e33
docs: clarify localPath usage
simleo 8c16c88
file.write: strip rde id to get relative path when applicable
simleo ff6a267
override dest with localPath only when downloading a remote file
simleo deda277
fix remote dir handling
simleo 9d52960
merge master into detached_crates
simleo 5eeccdc
remove docs on writing a detached crate "as attached"
simleo 35cb0b8
don't override a relative dest_path with localPath (create mode)
simleo 6b84395
override dataset localPath with part localPath if set
simleo 5975361
fetch_remote on Dataset: skip Dataset parts
simleo fc61747
don't auto-set localPath after a download
simleo ba531a6
split long tests into smaller ones
simleo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.