Refactor activity feed cards for financial events and related-work API updates - #905
Refactor activity feed cards for financial events and related-work API updates#905nicktytarenko wants to merge 15 commits into
Quality Gate failed
Failed conditions
3.9% Duplication on New Code (required ≤ 3%)
Annotations
Check warning on line 43 in components/Funding/GrantContentSwitcher.tsx
sonarqubecloud / SonarCloud Code Analysis
Do not use Array index in keys
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV9AUM3U-UaN9XDx&open=AZ7MwV9AUM3U-UaN9XDx&pullRequest=905
Check failure on line 93 in components/Activity/lib/feedEntryAdapters.ts
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5VLoDYF6UPUsd5Js2&open=AZ-5VLoDYF6UPUsd5Js2&pullRequest=905
Check warning on line 254 in app/layouts/Navigation.tsx
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-9b0F5YF6UPUsdWKcp&open=AZ-9b0F5YF6UPUsdWKcp&pullRequest=905
Check warning on line 90 in components/Activity/WorkPreviewCard.tsx
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5VLiiYF6UPUsd5Jsy&open=AZ-5VLiiYF6UPUsd5Jsy&pullRequest=905
Check warning on line 17 in components/Activity/lib/activityWorkContext.ts
sonarqubecloud / SonarCloud Code Analysis
'@/types/work' imported multiple times.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV8DUM3U-UaN9XDo&open=AZ7MwV8DUM3U-UaN9XDo&pullRequest=905
Check failure on line 5 in components/Activity/lib/deriveActivityContext.ts
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV8LUM3U-UaN9XDp&open=AZ7MwV8LUM3U-UaN9XDp&pullRequest=905
Check warning on line 28 in components/Funding/FundActivityPageContent.tsx
sonarqubecloud / SonarCloud Code Analysis
Do not use Array index in keys
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5t7uSP1NBD9GnfoL2&open=AZ-5t7uSP1NBD9GnfoL2&pullRequest=905
Check warning on line 110 in app/activity/page.tsx
sonarqubecloud / SonarCloud Code Analysis
Use `new Array()` instead of `Array()`.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ9cZN_bmgmoNAKmU2pQ&open=AZ9cZN_bmgmoNAKmU2pQ&pullRequest=905
Check warning on line 6 in app/(home)/loading.tsx
sonarqubecloud / SonarCloud Code Analysis
Use `new Array()` instead of `Array()`.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-9SCEm_sm3M2mrhZhN&open=AZ-9SCEm_sm3M2mrhZhN&pullRequest=905
Check warning on line 241 in components/Activity/lib/activityWorkContext.ts
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5VLnvYF6UPUsd5Js1&open=AZ-5VLnvYF6UPUsd5Js1&pullRequest=905
Check warning on line 582 in types/feed.ts
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV-3UM3U-UaN9XDz&open=AZ7MwV-3UM3U-UaN9XDz&pullRequest=905
Check warning on line 16 in components/Funding/GrantContentSwitcher.tsx
sonarqubecloud / SonarCloud Code Analysis
Mark the props of the component as read-only.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV9AUM3U-UaN9XDv&open=AZ7MwV9AUM3U-UaN9XDv&pullRequest=905
Check failure on line 185 in app/layouts/Navigation.tsx
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 27 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-9b0F5YF6UPUsdWKco&open=AZ-9b0F5YF6UPUsdWKco&pullRequest=905
Check warning on line 28 in components/Funding/FundActivityPageContent.tsx
sonarqubecloud / SonarCloud Code Analysis
Use `new Array()` instead of `Array()`.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5t7uSP1NBD9GnfoL1&open=AZ-5t7uSP1NBD9GnfoL1&pullRequest=905
Check warning on line 57 in components/Activity/WorkPreviewCard.tsx
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5VLiiYF6UPUsd5Jsx&open=AZ-5VLiiYF6UPUsd5Jsx&pullRequest=905
Check warning on line 167 in components/Activity/lib/activityWorkContext.ts
sonarqubecloud / SonarCloud Code Analysis
Extract this nested ternary operation into an independent statement.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5VLnvYF6UPUsd5Js0&open=AZ-5VLnvYF6UPUsd5Js0&pullRequest=905
Check warning on line 12 in app/(home)/layout.tsx
sonarqubecloud / SonarCloud Code Analysis
Mark the props of the component as read-only.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-9SB-x_sm3M2mrhZhM&open=AZ-9SB-x_sm3M2mrhZhM&pullRequest=905
Check warning on line 43 in components/Funding/GrantContentSwitcher.tsx
sonarqubecloud / SonarCloud Code Analysis
Use `new Array()` instead of `Array()`.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV9AUM3U-UaN9XDw&open=AZ7MwV9AUM3U-UaN9XDw&pullRequest=905
Check warning on line 110 in app/activity/page.tsx
sonarqubecloud / SonarCloud Code Analysis
Do not use Array index in keys
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV9dUM3U-UaN9XDy&open=AZ7MwV9dUM3U-UaN9XDy&pullRequest=905
Check warning on line 41 in app/grant/[id]/[slug]/page.tsx
sonarqubecloud / SonarCloud Code Analysis
Remove this useless assignment to variable "grantId".
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ9cZOCWmgmoNAKmU2pR&open=AZ9cZOCWmgmoNAKmU2pR&pullRequest=905
Check failure on line 153 in components/Activity/lib/activityWorkContext.ts
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 41 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5VLnvYF6UPUsd5Jsz&open=AZ-5VLnvYF6UPUsd5Jsz&pullRequest=905
Check warning on line 7 in app/(home)/loading.tsx
sonarqubecloud / SonarCloud Code Analysis
Do not use Array index in keys
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-9SCEm_sm3M2mrhZhO&open=AZ-9SCEm_sm3M2mrhZhO&pullRequest=905
Check warning on line 6 in components/Activity/lib/activityWorkContext.ts
sonarqubecloud / SonarCloud Code Analysis
'@/types/work' imported multiple times.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV8DUM3U-UaN9XDn&open=AZ7MwV8DUM3U-UaN9XDn&pullRequest=905
Check warning on line 1150 in types/feed.ts
sonarqubecloud / SonarCloud Code Analysis
Prefer `Number.parseFloat` over `parseFloat`.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ7MwV-3UM3U-UaN9XD0&open=AZ7MwV-3UM3U-UaN9XD0&pullRequest=905
Check warning on line 87 in components/Funding/RecentlyVisitedCard.tsx
sonarqubecloud / SonarCloud Code Analysis
Mark the props of the component as read-only.
See more on https://sonarcloud.io/project/issues?id=ResearchHub_web&issues=AZ-5t7pWP1NBD9GnfoL0&open=AZ-5t7pWP1NBD9GnfoL0&pullRequest=905