Remove unused xml lib, update catch2 - #21
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
It introduces an API-breaking removal (XML header) without an explicit breaking-change strategy, and the Catch2 tag is set in a way that prevents user override via CMake cache.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the test infrastructure to fetch and build Catch2 v3 via CMake FetchContent, and removes the legacy rkcommon XML parsing/writing module from the library.
Changes:
- Add a dedicated
tests/external/catch2FetchContent setup and linkrkcommon_test_suiteagainstCatch2::Catch2. - Update the test runner to use
Catch::Session()(Catch2 v3). - Remove
rkcommon/xml/XML.{h,cpp}from the project and update docs/build metadata accordingly.
File summaries
| File | Description |
|---|---|
tests/external/catch2/CMakeLists.txt |
New FetchContent-based Catch2 v3 integration for tests. |
tests/CMakeLists.txt |
Adds Catch2 subdir and links test suite against Catch2 target. |
tests/catch_main.cpp |
Migrates test runner to Catch2 v3 session API. |
rkcommon/xml/XML.h |
Removes legacy XML public header. |
rkcommon/xml/XML.cpp |
Removes legacy XML implementation. |
rkcommon/CMakeLists.txt |
Drops XML source file from rkcommon library build. |
README.md |
Documents higher CMake requirement when building tests. |
CMakeLists.txt |
Pins Catch2 git tag used by FetchContent. |
Review details
- Files reviewed: 8/9 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
johguenther
force-pushed
the
guj/devel
branch
from
September 9, 2026 13:35
63ea1ac to
d191ca4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.