update catch2 and rkcommon - #37
Merged
Merged
Conversation
- Catch2 v3.16, no longer in-source (also fix the 2 Coverity issues) - rkcommon v1.15.4
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Updates Catch2 to v3.16.0 and rkcommon to v1.15.4, adapting test builds and syntax for the newer dependencies.
Changes:
- Integrates Catch2 through FetchContent and
Catch2WithMain. - Updates tests for Catch2 v3 compatibility.
- Updates rkcommon metadata, documentation, licensing, and changelog.
File summaries
| File | Description |
|---|---|
third-party-programs.txt |
Updates Catch2 attribution. |
testing/external/catch2/CMakeLists.txt |
Adds Catch2 FetchContent configuration. |
testing/CMakeLists.txt |
Includes the Catch2 dependency. |
testing/apps/vklTests.cpp |
Removes the obsolete custom test main. |
testing/apps/tests/vectorized_interval_iterator.cpp |
Initializes interval state. |
testing/apps/tests/sampling_utility.h |
Migrates dynamic Catch2 sections. |
testing/apps/tests/particle_volume_sampling.cpp |
Updates Catch2 diagnostics. |
testing/apps/tests/particle_volume_radius.cpp |
Updates diagnostics and avoids copying. |
testing/apps/tests/particle_volume_gradients.cpp |
Updates Catch2 diagnostics. |
testing/apps/tests/interval_iterator.cpp |
Avoids copying value ranges. |
testing/apps/tests/hit_iterator_epsilon.cpp |
Migrates dynamic Catch2 sections. |
testing/apps/CMakeLists.txt |
Links test executables with Catch2. |
superbuild/CMakeLists.txt |
Updates rkcommon version and hash. |
doc/compilation.md |
Documents updated test requirements. |
CMakeLists.txt |
Defines the Catch2 version. |
CHANGELOG.md |
Records dependency and requirement updates. |
Review details
- Files reviewed: 16/17 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.