Added size limit check for buffer stride - #567
Merged
Merged
Conversation
Collaborator
|
This does still not do the entire job. There is some "buffer range out of bounds" check in buffer.h line 251. First that check is wrong IMHO, as it should test to buffer_in->numBytes only on the right hand side and not multiply by stride_in. |
Collaborator
|
That check in buffer.h should better be placed inside rtcore.cpp actually, thus all valid checks are at main API wrapper file. |
Collaborator
|
The check offset + Nstride >= buffer_size can be written as Nstride >= buffer_size - offset. Also check first if offset <= buffer_size. |
Collaborator
Author
|
@svenwoop can you take another look? |
svenwoop
reviewed
Nov 4, 2025
svenwoop
requested changes
Nov 19, 2025
svenwoop
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preventing possible wrap to zero when itemCount * bufferStride exceed 64 bit uint limit.