Fixed compilation with internal task scheduler - #562
Merged
Merged
Conversation
Internal task scheduler is now outside of RTC namespace matching the other schedulers.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Moves the internal TaskScheduler out of the RTC namespace to align with other schedulers and fix compilation issues arising from prior dual-namespace exposure.
- Removed RTC_NAMESPACE_BEGIN / RTC_NAMESPACE_END wrapping and the conditional using-alias.
- Eliminated the explanatory comment about exporting symbols via RTC namespace without replacement.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| common/tasking/taskschedulerinternal.h | Removed RTC namespace wrapping, alias, and related comment; TaskScheduler now directly in embree namespace. |
| common/tasking/taskschedulerinternal.cpp | Removed RTC namespace macro wrappers around implementation to match header change. |
Comments suppressed due to low confidence (2)
common/tasking/taskschedulerinternal.h:1
- The removal of this explanatory comment without a replacement loses rationale for prior namespace handling. If the dual-namespace exposure is intentionally deprecated, add a brief comment stating that TaskScheduler is now only in embree:: to align with other schedulers and that the RTC namespace exposure was removed.
// Copyright 2009-2021 Intel Corporation
common/tasking/taskschedulerinternal.h:1
- Removing RTC_NAMESPACE_END and the conditional using-alias eliminates the symbol path (e.g. rtc::TaskScheduler or whatever RTC_NAMESPACE expands to). This is a potential breaking change for downstream code that referenced the namespaced version. Consider providing a backward-compatibility typedef/alias guarded by a deprecation macro until the next major release, or document the breaking change explicitly.
// Copyright 2009-2021 Intel Corporation
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
svenwoop
approved these changes
Oct 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Internal task scheduler is now outside of RTC namespace matching the other schedulers.