Skip to content

[MOD-19327] Bump VecSim to remove id reuse from the tiered HNSW index - #12074

Merged
nonirosenfeldredis merged 2 commits into
masterfrom
sharon-MOD-19327-bump-vecsim-no-reuse
Nov 1, 2026
Merged

nonirosenfeldredis merged 2 commits into
masterfrom
sharon-MOD-19327-bump-vecsim-no-reuse

Conversation

@nonirosenfeldredis

@nonirosenfeldredis nonirosenfeldredis commented Oct 29, 2026 •

Copy link
Copy Markdown
Collaborator

Describe the changes in the pull request

  1. Current: VecSim reuses the internal id of an updated vector in the tiered HNSW index. That path takes an exclusive main-index lock for every in-place insert, which cut vector-update throughput (about 1.1k vs 4.4k ops/s in a local run).
  2. Change: Advance the VecSim submodule to the commit that removes id reuse from the tiered HNSW index ([MOD-19327] Remove id reuse from the tiered HNSW index RedisAI/VectorSimilarity#1085). The previous pin is the commit right before it, so this pulls in that change only.
  3. Outcome: Vector updates no longer take the exclusive lock for id reuse. The reuse is only in 8.12 pre-release builds (first in v8.11.90), not in 8.10 or earlier. Insert-path reuse (off by default) is a separate follow-up in VecSim.

Which additional issues this PR fixes

  1. MOD-19327

Main objects this PR modified

  1. deps/VectorSimilarity submodule pointer.

Mark if applicable

  • This PR introduces API changes
  • This PR introduces serialization changes

Release Notes

  • This PR requires release notes
  • This PR does not require release notes

🤖 Generated with Claude Code

Advance deps/VectorSimilarity to the commit that removes id reuse from the
tiered HNSW index (RedisAI/VectorSimilarity#1085).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T23:28:07.691673Z 0a5d8a0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

ofiryanai
ofiryanai previously approved these changes Oct 29, 2026
Without id reuse an overwrite's insert is queued right away, so the job
accounting has no held inserts, and the replaced vector's slot stays marked
deleted until the GC compacts it.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.92%. Comparing base (3dd97c1) to head (0a5d8a0).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12074      +/-   ##
==========================================
- Coverage   83.93%   83.92%   -0.01%     
==========================================
  Files         688      688              
  Lines       89404    89425      +21     
  Branches    11578    11578              
==========================================
+ Hits        75037    75054      +17     
- Misses      10673    10684      +11     
+ Partials     3694     3687       -7     
Flag Coverage Δ
flow 72.28% <ø> (-0.06%) ⬇️
unit 58.62% <ø> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

Copy link
Copy Markdown

@nonirosenfeldredis
nonirosenfeldredis added this pull request to the merge queue Nov 1, 2026
Merged via the queue into master with commit fd9fab9 Nov 1, 2026
64 checks passed
@nonirosenfeldredis
nonirosenfeldredis deleted the sharon-MOD-19327-bump-vecsim-no-reuse branch November 1, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants