Skip to content

CherryPicked: [cnv-4.22] [virt] fix test_restart_persistence_windows failing on ssh timeout#5141

Merged
rnetser merged 1 commit into
cnv-4.22from
CherryPicked-vk-fix-persistent-vm-test-nFMB7
Jun 8, 2026
Merged

CherryPicked: [cnv-4.22] [virt] fix test_restart_persistence_windows failing on ssh timeout#5141
rnetser merged 1 commit into
cnv-4.22from
CherryPicked-vk-fix-persistent-vm-test-nFMB7

Conversation

@cnv-tests-github-webhook-dollierp

Copy link
Copy Markdown

Cherry-pick from main branch, original PR: #5103, PR owner: vsibirsk

…5103)

##### What this PR does / why we need it:
increased command exec timeout (powershell commands might take 5+ sec to
exec and report status via ssh)

##### Which issue(s) this PR fixes:

##### Special notes for reviewer:

##### jira-ticket:

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Extended timeout duration for SSH command execution to improve
reliability and reduce premature termination.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: Vasiliy Sibirskiy <vsibirsk@redhat.com>
@openshift-virtualization-qe-bot-4

Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • dshchedr
  • myakove
  • rnetser
  • vsibirsk

Reviewers:

  • RoniKishner
  • dshchedr
  • geetikakay
  • rnetser
  • vsibirsk
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is removed on new commits unless the push is detected as a clean rebase
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@vsibirsk

vsibirsk commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/retest verify-bugs-are-open

@vsibirsk

vsibirsk commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/verified

@vsibirsk

vsibirsk commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/lgtm
/approve

@rnetser

rnetser commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

/approve
/lgtm

@rnetser rnetser merged commit fe2f1e1 into cnv-4.22 Jun 8, 2026
21 checks passed
@rnetser rnetser deleted the CherryPicked-vk-fix-persistent-vm-test-nFMB7 branch June 8, 2026 13:57
@openshift-virtualization-qe-bot-5

Copy link
Copy Markdown

New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.22 published

josemacassan pushed a commit to josemacassan/openshift-virtualization-tests that referenced this pull request Jun 15, 2026
…failing on ssh timeout (RedHatQE#5141)

Cherry-pick from `main` branch, original PR:
RedHatQE#5103, PR
owner: vsibirsk

Signed-off-by: Vasiliy Sibirskiy <vsibirsk@redhat.com>
Co-authored-by: Vasiliy Sibirskiy <vsibirsk@redhat.com>
Signed-off-by: Jose Manuel Castano <joscasta@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants