Skip to content

fix: improve smoke test conftest-hierarchy tracing in CodeRabbit instructions #5096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnetser merged 2 commits into from
Jun 2, 2026
Merged

fix: improve smoke test conftest-hierarchy tracing in CodeRabbit instructions #5096

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcd20b7
fix: improve smoke test conftest-hierarchy tracing in CodeRabbit inst…
rnetser Jun 1, 2026
ea003f6
fix: resolve rule conflict in smoke test impact logic
rnetser Jun 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/request-coderabbit-test-instructions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,17 @@ jobs:
Do NOT limit impact to tests that import the modified symbol only.
7. **Smoke test impact:** Intersect the affected set from step 6 with smoke-marked tests.
Run: `rg -l '@pytest.mark.smoke' tests/`
VERIFY the above command returned actual file paths before concluding False.
Comment thread
rnetser marked this conversation as resolved.
Set True ONLY if a smoke-marked file also appears in the affected set from 6b-6e.
For each smoke-marked file, ALSO check its conftest.py hierarchy (parent directory
conftest.py files up to the repo root) for imports of modified utilities/libs symbols.
A smoke test is affected if ANY conftest.py in its hierarchy imports a transitively
modified symbol — even when the test file itself has no direct import.
This includes autouse fixtures: if a conftest.py defines an autouse fixture that
calls or imports a modified function, ALL tests in that directory (and below) are affected.
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
Example check: for each smoke_file, scan dirname(smoke_file)/conftest.py,
dirname(dirname(smoke_file))/conftest.py, etc. for modified symbol imports
and autouse fixtures that depend on modified symbols.
8. **Gating test impact:** Intersect the affected set from step 6 with gating-marked tests.
Run: `rg -l '@pytest.mark.gating' tests/`
Set True if a gating-marked file also appears in the affected set from 6b-6e.
Expand Down