Change declared order in which red and green on ws2812 color's definition - #47
Open
akari-tun wants to merge 1 commit into
Open
Change declared order in which red and green on ws2812 color's definition#47akari-tun wants to merge 1 commit into
akari-tun wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that in FAILSAFE mode, the LED did not flash red. Looking at the code, I found that the red and green colors in hal_ws2812_color_s were incorrect for the parameters passed in the HAL_WS2812_RGB definition.I don't know if this was a BUG or was intentional, but after I changed the order, the LED was flashing the correct red in FAILSAFE mode.