Skip to content

fix(idex): refine parking space sanity check to detect and allow configurations where T1 homes against T0 - #149

Merged
tg73 merged 1 commit into
Rat-OS:v2.1.x-developmentfrom
tg73:topic/devpub/support-homing-t0-against-t1
Jul 3, 2026
Merged

fix(idex): refine parking space sanity check to detect and allow configurations where T1 homes against T0#149
tg73 merged 1 commit into
Rat-OS:v2.1.x-developmentfrom
tg73:topic/devpub/support-homing-t0-against-t1

Conversation

@tg73

@tg73 tg73 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Bug Fixes
    • Improved dual-extruder start-up checks so the printer uses the correct parking-space boundary more consistently.
    • Made print setup values available earlier in the start sequence, reducing the chance of incorrect toolhead positioning checks.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 17d93982-b7a0-4afb-83da-7bb708c9b380

📥 Commits

Reviewing files that changed from the base of the PR and between 1df0f23 and 7a0be86.

📒 Files selected for processing (1)
  • configuration/macros.cfg

📝 Walkthrough

Walkthrough

The START_PRINT macro in configuration/macros.cfg now caches printable_x_max earlier so it is available for the IDEX toolhead x-offset sanity check. The dc_parking_space calculation is changed to conditionally select a boundary based on comparison with printable_x_max / 2.0, and a redundant later assignment is removed.

Changes

IDEX Parking-Space Calculation Fix

Layer / File(s) Summary
Reordered caching and conditional parking-space logic
configuration/macros.cfg
printable_x_max is now cached earlier in START_PRINT; dc_parking_space is computed conditionally based on whether dual_carriage_position_endstop is less than printable_x_max / 2.0, replacing the prior unconditional min(...) logic; the later redundant printable_x_max assignment is removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Related Issues: Not specified in the provided information.

Related PRs: Not specified in the provided information.

Suggested labels: bug, macros

Suggested reviewers: Not specified in the provided information.

Poem
A rabbit hopped through gcode lines,
Where carriages park by careful signs,
No longer bound to min() alone,
Now half the bed's own width is known,
Hop, tweak, done — the print begins. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the IDEX parking-space sanity check change and its goal of allowing T1-to-T0 homing configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tg73

tg73 commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@tg73
tg73 merged commit 1b2ab13 into Rat-OS:v2.1.x-development Jul 3, 2026
2 of 3 checks passed
@tg73
tg73 deleted the topic/devpub/support-homing-t0-against-t1 branch July 3, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant