feat(macros): add user hooks to _PURGE_FILAMENT - #148
Merged
tg73 merged 3 commits intoJul 3, 2026
Conversation
- Added empty _USER_BEFORE_PURGE_FILAMENT TOOLHEAD=0|1 and _USER_AFTER_PURGE_FILAMENT TOOLHEAD=0|1 - Called around the main block in _PURGE_FILAMENT, but only if purging will actually take place.
…s not ints - existing callers often pass floats, and it makes no sense to force these parameters to be integers
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe _PURGE_FILAMENT macro now parses E and R parameters as floats and logs both values via DEBUG_ECHO. Two new user hook calls, _USER_BEFORE_PURGE_FILAMENT and _USER_AFTER_PURGE_FILAMENT, are invoked during the purge sequence when E > 0, with corresponding empty macro stubs added to user-hooks.cfg. ChangesPurge Filament Hooks
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit