merge main into amd-staging#3100
Merged
Merged
Conversation
This test was meant to round-trip YAML twice, to ensure correct processing of non-4-byte-padded PRIV section. However, second invocation of yaml2obj had wrong arguments (it was reading from test file instead of stdin). Fix that. Also, round-trips were split into several RUN lines, to make it clear on which line an error occurs if the test is still flaky.
This patch makes two improvements to colors used in FileCheck input
dumps:
1. Without this patch, input line numbers and ellipses have a foreground
color of black, which is hard to see in a terminal with a dark color
theme. This patch changes that to bright black (a grayish color), which
looks good to me for all terminal themes I have tried while remaining
distinct from the input text.
2. Without this patch, the input text is accidentally set to bold when
neither `-v` or `-vv` is specified. Perhaps I never noticed because I
tend to always use `-vv`. This patch changes that to use the terminal's
default color.
Case 2 exposes a problem with LLVM's color implementation. Without this
patch, the call to `WithColor`'s constructor actually specifies bold as
`false`, but `WithColor` ignores that when the color is `SAVEDCOLOR`.
While it seems like that should be fixed, I am concerned about the
impact of such a fix on other tools that might have come to
inadvertently depend on the old behavior. For now, this patch adds fixme
comments to the color APIs.
To facilitate testing, this patch adds a lit substitution with a sed
script that translates ANSI escape sequences into plain text format with
symbolic names. It also updates an existing FileCheck test to use it.
Expose IRMapping through the MLIR C API with full create/destroy/map, lookup, contains/erase, and clone-with-mapping functionality. Assisted by: Claude
Re-exposes LLVM-libc's `__subdf3` as `shared::subdf3` for reuse by compiler-rt's builtins. Stacked change - merge these first: - llvm#200094 - llvm#205669 - llvm#205670 - llvm#205671 - llvm#205672 Part of llvm#197824
This fixes 9889e62. Co-authored-by: Google Bazel Bot <google-bazel-bot@google.com>
…rs (llvm#205711) `RedZoneSize` is only read inside `#if LLVM_ADDRESS_SANITIZER_BUILD`. Additionally gate it under `LLVM_ENABLE_ABI_BREAKING_CHECKS` so that release-non-assertions builds don't incur the overhead. To support non-asan build with asan library users, the variable is only omitted in `!LLVM_ENABLE_ABI_BREAKING_CHECKS` builds. `BytesAllocated` is incremented on every Allocate (a hot-path memory read-modify-write) only to back `getBytesAllocated()`. Drop the member. There is a measurable stage2 instruction-count reduction. https://llvm-compile-time-tracker.com/compare.php?from=25a6b5be6853b2c493ef392d41e43dd35ad4839a&to=8ebc975635ad717deb392d20b50f1a1f6bb16054&stat=instructions:u Migrate the in-tree consumers: - TableGen dumpAllocationStats drops the line; the clangd debug log reports getTotalMemory(). - clang's PPMemoryAllocationsTest measures getTotalMemory()/#define; over 1M defines this is 120.06 B/define, matching the prior ~120 B, so the existing bound holds. - lldb's ConstString MemoryStats (https://reviews.llvm.org/D117914) drops bytes_used/bytes_unused Aided by Claude Opus 4.8
ronlieb
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.