Skip to content

AMDGPU: add hotswap entry trampoline lit coverage#3098

Draft
harsh-amd wants to merge 1 commit into
ROCm:users/harsh/comgr-hotswap-entry-corefrom
harsh-amd:comgr-hotswap-entry-lit
Draft

AMDGPU: add hotswap entry trampoline lit coverage#3098
harsh-amd wants to merge 1 commit into
ROCm:users/harsh/comgr-hotswap-entry-corefrom
harsh-amd:comgr-hotswap-entry-lit

Conversation

@harsh-amd

@harsh-amd harsh-amd commented Jun 27, 2026

Copy link
Copy Markdown

Stack:

  1. AMDGPU: add hotswap entry trampoline core #3008 - core hotswap entry trampoline implementation, unit coverage, and minimal public LIT coverage.
  2. This PR - expanded LIT coverage layered on top of AMDGPU: add hotswap entry trampoline core #3008.

The base branch users/harsh/comgr-hotswap-entry-core mirrors the #3008 head so GitHub shows this as an incremental stack diff.

Summary:

  • Adds default-disabled and explicitly disabled entry-trampoline checks.
  • Adds idempotency coverage for already-rewritten entry trampolines.
  • Adds B0/A0 stepping interaction coverage.
  • Adds gfx12.5-family and multi-kernel LIT coverage.
  • Keeps broader public API/LIT coverage separate from the core implementation PR.

Verification:

  • Rebased onto AMDGPU: add hotswap entry trampoline core #3008 core at 1de7a53.
  • cmake --build build --target HotswapMCTests HotswapElfTests hotswap-rewrite -- -j8 passed.
  • build/bin/HotswapMCTests passed: 36 tests.
  • build/bin/HotswapElfTests passed: 13 tests.
  • build/bin/llvm-lit -sv build/tools/comgr/test-lit --filter hotswap passed: 53 tests.
  • git diff --check rocm/amd-staging...HEAD passed on the stack top.
  • The final stack tip remains tree-identical to the previous full top-of-stack before moving minimal LIT coverage into AMDGPU: add hotswap entry trampoline core #3008.

@harsh-amd harsh-amd marked this pull request as draft June 27, 2026 23:05
@harsh-amd harsh-amd force-pushed the comgr-hotswap-entry-lit branch from c57e712 to 4159416 Compare June 27, 2026 23:06
@harsh-amd harsh-amd force-pushed the users/harsh/comgr-hotswap-entry-core branch from 280c69b to 737534a Compare June 27, 2026 23:07
@harsh-amd harsh-amd force-pushed the comgr-hotswap-entry-lit branch from 4159416 to a65cf8d Compare June 28, 2026 18:09
@harsh-amd harsh-amd force-pushed the users/harsh/comgr-hotswap-entry-core branch from 737534a to 1de7a53 Compare June 28, 2026 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant