Dev/fly pa reduce jit build#3944
Open
Bernard-Liu wants to merge 4 commits into
Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Gluon paged-attention PS-reduce path to reduce runtime JIT “build wall” by eagerly compiling FlyDSL partition-count variants and tightening compile-time specialization in the FlyDSL kernel.
Changes:
- Introduces eager precompilation of FlyDSL PS-reduce sibling variants (partition counts 1..8) on first use per config to reduce later mid-run JIT.
- Uses
flydsl.expr.const_exprfor several kernel conditionals to force compile-time branching, and adjusts onearith.bitcastcall to unwrap the source value. - Refactors PS reduce wrapper selection to try FlyDSL first (when available), then C++ PS-reduce, then Triton.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # variants so a later call landing on a different get_recommended_splits value | ||
| # hits the cache instead of JIT-compiling mid-run. Thread-safe: no global env | ||
| # toggling, and the test-and-add is locked so only one thread does the work. | ||
| sig = tuple(sorted(compile_kwargs.items())) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist