chore(compiler): bump amd-llvm to ww19.4 (remove COMGR hotswap tool)#6155
Merged
Conversation
Advances the amd-llvm pin by one commit over the current ww19.3 pin (46fcb339): ROCm/llvm-project#3007, which removes the comgr-side hotswap HSA tool (libamd_comgr_hotswap_tool.so). COMGR keeps the amd_comgr_hotswap_rewrite API; the HSA tool now lives in rocm-systems (libhsa-hotswap.so). Pin-only change. Nothing in TheRock depends on the removed tool, and the existing -DHOTSWAP_BUILD_TOOL=ON arg becomes a harmless unused-variable warning (the option no longer exists in comgr). The TheRock CMake cleanup and the rocm-systems side land separately.
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
therock-pr-bot
Bot
added
the
Not ready to Review
|
🎉 All checks passed! This PR is ready for review. |
lamb-j
changed the title
therock-pr-bot
Bot
removed
the
Not ready to Review
Contributor
|
build fail: [rocFFT] terminate called after throwing an instance of 'std::runtime_error' |
The previous pin pointed at 8887092c2e8 (#2964 "Make HotSwap tool detection helpers LLVM-free"), which is an ancestor of the base pin 46fcb339. That moved the compiler backwards and reverted 46fcb339 "[Comgr] Fix hotswap transpiler link order breaking in-process LLD", causing rocFFT's in-process LLD to fail with "ld.lld: error: -plugin-opt=mcpu=: Unknown command line argument". Re-point to aa451e1f (#3007 "Remove COMGR hotswap HSA tool"), the intended ww19.4 target. This is now a clean forward-only bump of a single commit over the base. ISSUE ID: #6096
ronlieb
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISSUE ID: #6096
Summary
Pin-only amd-llvm SMP bump:
46fcb339(ww19.3) →aa451e1f(ww19.4), adding one commit — ROCm/llvm-project#3007, which removes the comgr-side hotswap HSA tool (libamd_comgr_hotswap_tool.so). COMGR retains theamd_comgr_hotswap_rewriteAPI; the HSA_TOOLS_LIB tool now lives in rocm-systems (libhsa-hotswap.so, separate PRs).Why this is safe standalone
libamd_comgr_hotswap_tool.so, so removing it breaks no build or packaging step.-DHOTSWAP_BUILD_TOOL=ONto comgr; after Revert "[ALMIOPEN-895] Remove positive filter to include missing test… #3007 that option no longer exists, so it becomes a harmless unused-variable warning, not an error.HSA_TOOLS_LIB-gated (unset by default), so there is no runtime behavior change.Scope
This PR is only the
compiler/amd-llvmpin. The companion TheRock CMake cleanup (dropping the deadHOTSWAP_BUILD_TOOLwiring, building the rocm-systemslibhsa-hotswap.so) and the rocm-systems SMP bump land separately.