bugfix: Add ABC to classes using @abstractmethod - #95
Open
MrCrystAll wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug/Problem
The config objects (ObsBuilder, ActionParser, ...) aren't inheriting ABC despite using the @AbstractMethod decorator.
From the python documentation:
Using this decorator requires that the class’s metaclass is [ABCMeta](https://docs.python.org/3.14/library/abc.html#abc.ABCMeta) or is derived from it. A class that has a metaclass derived from ABCMeta cannot be instantiated unless all of its abstract methods and properties are overridden.ABCMeta can either be used by writing
metaclass=ABCMetaor by inheriting ABC (see https://docs.python.org/3.14/library/abc.html#abc.ABC).The reason why i'm making a fix for it isn't only regarding the documentation, inheriting ABC allows type introspection scripts to mark the object as abstract. I also believe some IDEs base their override menu on the ABC inheritance