Repository navigation
repro + fix: rgb inflight htlc checks - #45
Open
orbitalturtle wants to merge 2 commits into
Open
orbitalturtle wants to merge 2 commits into
orbitalturtle wants to merge 2 commits into
Conversation
Lets a test make a sender put an arbitrary RGB payment on every hop, like a payer whose wire client is not bound by the invoice. It also rewrites the sender's outbound RGB payment info file so commitment coloring agrees with the HTLC. Co-Authored-By: Claude
Balance checks only looked at the settled RGB balance, so several pending HTLCs could together exceed it, making the sender panic while coloring the commitment. They now subtract RGB already in flight, and incoming HTLCs must carry the channel's asset. Co-Authored-By: Claude
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RGB balance checks ignored HTLCs already in flight, so two pending payments could together exceed the channel's RGB balance and make the sender panic (subtract overflow in color_commitment). Outbound and inbound checks now subtract in-flight RGB, and incoming HTLCs must carry the channel's asset.
This branch includes the FORCE_PATH_RGB_PAYMENT_ON_NODE test hook commit from #40. If #40 is merged first, we'll drop that commit here and rebase.
🚨 CI depends on #41, so please merge that first.