Skip to content

fix(ci): rename triage status marker to avoid duplicate-guard collision #7723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wenshao merged 11 commits into from
Jul 26, 2026
+93 −49
Merged

fix(ci): rename triage status marker to avoid duplicate-guard collision #7723

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
af9dcb0
fix(ci): rename triage status marker to avoid duplicate-guard collision
yiliang114 Jul 25, 2026
86fe06c
fix(ci): update test assertions for renamed triage lifecycle marker
yiliang114 Jul 25, 2026
74fb91d
fix(ci): sync triage finalize status marker
yiliang114 Jul 25, 2026
bf197af
test(ci): cover triage status marker parity
yiliang114 Jul 25, 2026
af675e7
fix(ci): preserve triage marker consumers
yiliang114 Jul 26, 2026
206d1c5
Merge branch 'main' into fix/triage-lifecycle-marker
wenshao Jul 26, 2026
3edf3b8
test(ci): pin triage lifecycle marker checks
yiliang114 Jul 26, 2026
845d375
fix(ci): add bot-author filter and startswith to triage status lookups
yiliang114 Jul 26, 2026
756ef6c
fix(ci): guard triage status bot lookup
yiliang114 Jul 26, 2026
a567c05
Merge branch 'main' into fix/triage-lifecycle-marker
yiliang114 Jul 26, 2026
7bb6794
Merge branch 'main' into fix/triage-lifecycle-marker
yiliang114 Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/qwen-triage-finalize.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ jobs:
CI_BEGIN="<!-- qwen-triage-ci sha=${HEAD_SHA} -->"
CI_END='<!-- /qwen-triage-ci -->'
APPROVE_MARKER="<!-- qwen-triage approve-on-green sha=${HEAD_SHA} -->"
STATUS_MARKER='<!-- qwen-triage stage=status -->'
STATUS_MARKER='<!-- qwen-triage-lifecycle -->'
Comment thread
yiliang114 marked this conversation as resolved.
Outdated

if ! BOT_LOGIN="$(gh api user --jq '.login')" || [ -z "$BOT_LOGIN" ]; then
echo "::warning::Cannot resolve the bot identity; skipping (markers cannot be author-verified)."
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/qwen-triage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ jobs:
RUN_URL: '${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}'
run: |-
set -uo pipefail
MARKER='<!-- qwen-triage stage=status -->'
MARKER='<!-- qwen-triage-lifecycle -->'
Comment thread
yiliang114 marked this conversation as resolved.
Outdated
printf -v BODY '%s\n\n%s\n\n%s' \
"$MARKER" \
"🔄 **Qwen Triage is running** — [watch live progress]($RUN_URL). Stage results will post in this thread as they complete." \
Expand Down Expand Up @@ -637,7 +637,7 @@ jobs:
TRIAGE_OUTCOME: '${{ steps.triage.outcome }}'
run: |-
set -uo pipefail
MARKER='<!-- qwen-triage stage=status -->'
MARKER='<!-- qwen-triage-lifecycle -->'
Comment thread
yiliang114 marked this conversation as resolved.
Outdated
if [ "${TRIAGE_OUTCOME:-}" = 'success' ]; then
EN="✅ **Qwen Triage finished** — [view run]($RUN_URL). See the stage comments in this thread for the result."
ZH="✅ **Qwen Triage 已完成** —— [查看运行]($RUN_URL)。结果见本线程中的各阶段评论。"
Expand Down
4 changes: 2 additions & 2 deletions scripts/tests/qwen-triage-workflow.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ describe('qwen-triage tmux workflow', () => {
it('posts an early live-progress status comment and finalizes the same one', () => {
const statusStep = step('Post triage status comment');
// Announced up front (before the long agent step) with the live run link.
expect(statusStep).toContain('<!-- qwen-triage stage=status -->');
expect(statusStep).toContain('<!-- qwen-triage-lifecycle -->');
expect(statusStep).toContain('actions/runs/${{ github.run_id }}');
expect(statusStep).toContain('watch live progress');
// Upsert by marker so a re-run reuses the one comment instead of stacking.
Expand All @@ -225,7 +225,7 @@ describe('qwen-triage tmux workflow', () => {

const finalizeStep = step('Finalize triage status comment');
// Runs on both outcomes and edits the SAME marker comment (no second post).
expect(finalizeStep).toContain('<!-- qwen-triage stage=status -->');
expect(finalizeStep).toContain('<!-- qwen-triage-lifecycle -->');
expect(finalizeStep).toContain('success() || failure()');
expect(finalizeStep).toContain('steps.triage.outcome');
expect(finalizeStep).toContain('--method PATCH');
Expand Down
Loading