Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 97 additions & 0 deletions packages/cli/src/ui/hooks/useGeminiStream.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9099,6 +9099,103 @@ describe('useGeminiStream', () => {
}
});

it('should keep terminal error visible at turn completion', async () => {
mockSendMessageStream.mockReturnValue(
(async function* () {
yield {
type: ServerGeminiEventType.Error,
value: { error: { message: 'Fatal API error' } },
};
})(),
);

const { result } = renderTestHook();

await act(async () => {
await result.current.submitQuery('Trigger terminal error');
});

await waitFor(() => {
const errorItem = result.current.pendingHistoryItems.find(
(item) => item.type === 'error',
);
expect(errorItem).toBeDefined();
expect((errorItem as { hint?: string })?.hint).toContain('Ctrl+Y');
});
});

it('should clear stale countdown error when retry succeeds without a second Retry event', async () => {
vi.useFakeTimers();
try {
let continueAfterCountdown: (() => void) | undefined;
mockSendMessageStream.mockReturnValue(
(async function* () {
yield {
type: ServerGeminiEventType.Retry,
retryInfo: {
message: '[API Error: Socket closed]',
attempt: 1,
maxRetries: 3,
delayMs: 1000,
},
};
await new Promise<void>((resolve) => {
continueAfterCountdown = resolve;
});
yield {
type: ServerGeminiEventType.Content,
value: 'Recovered content',
};
yield {
type: ServerGeminiEventType.Finished,
value: { reason: 'STOP', usageMetadata: undefined },
};
})(),
);

const { result } = renderTestHook();

act(() => {
void result.current.submitQuery('Trigger retry');
});

await act(async () => {
await Promise.resolve();
await vi.advanceTimersByTimeAsync(0);
});

let errorItem = result.current.pendingHistoryItems.find(
(item) => item.type === MessageType.ERROR,
);
for (let attempts = 0; attempts < 5 && !errorItem; attempts++) {
await act(async () => {
await Promise.resolve();
});
errorItem = result.current.pendingHistoryItems.find(
(item) => item.type === MessageType.ERROR,
);
}
expect(errorItem).toBeDefined();

await act(async () => {
await vi.advanceTimersByTimeAsync(1000);
});

await act(async () => {
continueAfterCountdown?.();
await Promise.resolve();
await Promise.resolve();
});

const remainingError = result.current.pendingHistoryItems.find(
(item) => item.type === MessageType.ERROR,
);
expect(remainingError).toBeUndefined();
} finally {
vi.useRealTimers();
}
});

it('should memoize pendingHistoryItems', () => {
mockUseReactToolScheduler.mockReturnValue([
[],
Expand Down
9 changes: 9 additions & 0 deletions packages/cli/src/ui/hooks/useGeminiStream.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2942,6 +2942,15 @@ export const useGeminiStream = (
// a new conversation turn (cleared in submitQuery).
if (retryCountdownTimerRef.current) {
clearRetryCountdown();
} else if (
pendingRetryErrorItemRef.current &&
!lastPromptErroredRef.current
) {
// A countdown-originated error item lingers after the timer
// expired and the retry succeeded. Clear it so it does not
// stay on screen. Terminal errors (handleErrorEvent) set
// lastPromptErroredRef and are intentionally left visible.
setPendingRetryErrorItem(null);
}
Comment thread
qwen-code-dev-bot marked this conversation as resolved.
const loopDetected = loopDetectedRef.current;
if (loopDetected) {
Expand Down
Loading